Re: [patch] PR inline-asm/55934

2013-01-24 Thread Steven Bosscher
On Wed, Jan 23, 2013 at 7:43 PM, Vladimir Makarov wrote: > The error occurs because a pseudo in asm insn is not changed into hard > register as the pseudo info is incorrect after info updating. > > You should just use lra_update_insn_regno_info. The patch (and the patch is > ok to commit) should lo

Re: [patch] PR inline-asm/55934

2013-01-23 Thread Vladimir Makarov
On 13-01-22 4:41 AM, Steven Bosscher wrote: On Mon, Jan 21, 2013 at 5:22 PM, Vladimir Makarov wrote: I'd prefer the above change than just keeping lra_invalidate_insn_data call. I think it is more safe solution for other parts of LRA code. I agree, but unfortunately the compiler does not... W

Re: [patch] PR inline-asm/55934

2013-01-22 Thread Steven Bosscher
On Mon, Jan 21, 2013 at 5:22 PM, Vladimir Makarov wrote: > I'd prefer the above change than just keeping > lra_invalidate_insn_data call. I think it is more safe solution for other > parts of LRA code. I agree, but unfortunately the compiler does not... With that lra.c change, I get extra fails:

Re: [patch] PR inline-asm/55934

2013-01-21 Thread Vladimir Makarov
On 13-01-19 11:57 AM, Steven Bosscher wrote: On Sat, Jan 19, 2013 at 1:15 AM, Vladimir Makarov wrote: On 13-01-17 6:45 PM, Steven Bosscher wrote: Hello Vlad, Attached is my attempt to fix PR55934, an error recovery issue in LRA with incorrect constraints in an asm. I'm not 100% sure this is a

Re: [patch] PR inline-asm/55934

2013-01-19 Thread Steven Bosscher
On Sat, Jan 19, 2013 at 1:15 AM, Vladimir Makarov wrote: > On 13-01-17 6:45 PM, Steven Bosscher wrote: >> >> Hello Vlad, >> >> Attached is my attempt to fix PR55934, an error recovery issue in LRA >> with incorrect constraints in an asm. >> >> I'm not 100% sure this is all correct (especially the L

Re: [patch] PR inline-asm/55934

2013-01-18 Thread Vladimir Makarov
On 13-01-17 6:45 PM, Steven Bosscher wrote: Hello Vlad, Attached is my attempt to fix PR55934, an error recovery issue in LRA with incorrect constraints in an asm. I'm not 100% sure this is all correct (especially the LRA insn data invalidating in lra-assigns.c) but it appears to fix the PR wit

Re: [patch] PR inline-asm/55934

2013-01-18 Thread Steven Bosscher
On Fri, Jan 18, 2013 at 12:59 AM, Jakub Jelinek wrote: > On Fri, Jan 18, 2013 at 12:45:06AM +0100, Steven Bosscher wrote: >> --- testsuite/gcc.target/i386/pr55934.c (revision 0) >> +++ testsuite/gcc.target/i386/pr55934.c (revision 0) >> @@ -0,0 +1,10 @@ >> +/* PR inline-asm/55934 */ >> +/* { dg-do

Re: [patch] PR inline-asm/55934

2013-01-17 Thread Jakub Jelinek
On Fri, Jan 18, 2013 at 12:45:06AM +0100, Steven Bosscher wrote: > --- testsuite/gcc.target/i386/pr55934.c (revision 0) > +++ testsuite/gcc.target/i386/pr55934.c (revision 0) > @@ -0,0 +1,10 @@ > +/* PR inline-asm/55934 */ > +/* { dg-do compile } */ > +/* { dg-require-effective-target sse } */ Don

[patch] PR inline-asm/55934

2013-01-17 Thread Steven Bosscher
Hello Vlad, Attached is my attempt to fix PR55934, an error recovery issue in LRA with incorrect constraints in an asm. I'm not 100% sure this is all correct (especially the LRA insn data invalidating in lra-assigns.c) but it appears to fix the PR without introducing test suite failures. Can you