Re: [patch] implement generic debug() functions for wide_int's

2017-10-19 Thread Aldy Hernandez
On 10/18/2017 11:23 PM, Martin Sebor wrote: On 10/18/2017 11:08 AM, Aldy Hernandez wrote: It looks like the generic debug() function for wide_int's is missing. Instead, we have a wi->dump() method.  I have implemented debug() for generic wide_int and for widest_int, which should cover the

Re: [patch] implement generic debug() functions for wide_int's

2017-10-19 Thread Aldy Hernandez
On 10/18/2017 06:22 PM, Pedro Alves wrote: On 10/18/2017 06:08 PM, Aldy Hernandez wrote: Also, do we have a blessed way of specifying overloaded functions in ChangeLog's? I couldn't find anything in our GCC coding guidelines or in the GNU coding guidelines. For lack of direction, I'm doing

Re: [patch] implement generic debug() functions for wide_int's

2017-10-18 Thread Martin Sebor
On 10/18/2017 11:08 AM, Aldy Hernandez wrote: It looks like the generic debug() function for wide_int's is missing. Instead, we have a wi->dump() method. I have implemented debug() for generic wide_int and for widest_int, which should cover the common cases. Anything else, can continue using

Re: [patch] implement generic debug() functions for wide_int's

2017-10-18 Thread Pedro Alves
On 10/18/2017 06:08 PM, Aldy Hernandez wrote: > Also, do we have a blessed way of specifying overloaded functions in > ChangeLog's? I couldn't find anything in our GCC coding guidelines or > in the GNU coding guidelines. For lack of direction, I'm doing the > following: > > * wide-int.cc

Re: [patch] implement generic debug() functions for wide_int's

2017-10-18 Thread Mike Stump
On Oct 18, 2017, at 10:08 AM, Aldy Hernandez wrote: > > It looks like the generic debug() function for wide_int's is missing. > OK for trunk? Ok.

[patch] implement generic debug() functions for wide_int's

2017-10-18 Thread Aldy Hernandez
It looks like the generic debug() function for wide_int's is missing. Instead, we have a wi->dump() method. I have implemented debug() for generic wide_int and for widest_int, which should cover the common cases. Anything else, can continue using the ->dump() method templated methods. Also, do