Re: [v2][patch] plugin/plugin-nvptx.c: Fix fini_device call when already shutdown [PR113513]

Hi Thomas, Thomas Schwinge wrote: On 2024-01-23T10:55:16+0100, Tobias Burnus wrote: plugin/plugin-nvptx.c: Fix fini_device call when already shutdown [PR113513] The following issue was found when running libgomp.c/target-52.c with nvptx offloading when the dg-set-target-env-var was honored.

Re: [v2][patch] plugin/plugin-nvptx.c: Fix fini_device call when already shutdown [PR113513]

Hi Tobias! On 2024-01-23T10:55:16+0100, Tobias Burnus wrote: > Slightly changed patch: > > nvptx_attach_host_thread_to_device now fails again with an error for > CUDA_ERROR_DEINITIALIZED, except for GOMP_OFFLOAD_fini_device. > > I think it makes more sense that way. Agreed. > Tobias Burnus

[v2][patch] plugin/plugin-nvptx.c: Fix fini_device call when already shutdown [PR113513]

Slightly changed patch: nvptx_attach_host_thread_to_device now fails again with an error for CUDA_ERROR_DEINITIALIZED, except for GOMP_OFFLOAD_fini_device. I think it makes more sense that way. Tobias Burnus wrote: Testing showed that the libgomp.c/target-52.c failed with: libgomp:

[patch] plugin/plugin-nvptx.c: Fix fini_device call when already shutdown [PR113513]

Testing showed that the libgomp.c/target-52.c failed with: libgomp: cuCtxGetDevice error: unknown cuda error libgomp: device finalization failed This testcase uses OMP_DISPLAY_ENV=true and OMP_TARGET_OFFLOAD=mandatory, and those env vars matter, i.e. it only fails if dg-set-target-env-var is