Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-09 Thread Andrew MacLeod
On 07/08/2015 10:42 PM, Andrew MacLeod wrote: On 07/08/2015 06:43 PM, Jeff Law wrote: predict.h is actually required by gimple.h for a few reasons, enum be_predictor is used in parameter lists and a few inlines use the TAKEN, NOT_TAKEN macros Its also needed by cfghooks.h, and betwen those 2

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-09 Thread Jeff Law
On 07/08/2015 08:42 PM, Andrew MacLeod wrote: blah, not so trivial. One of the primary things predict.h does is create enum br_predictor by including predict,def.. so moving that enum doesnt really make sense. Fixing gimple,h isn't too bad, I could split the prediction stuff out into

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-09 Thread Andrew MacLeod
On 07/09/2015 01:49 PM, Jeff Law wrote: On 07/09/2015 11:06 AM, Andrew MacLeod wrote: The total result affect 227 files. Now, predict.h is *still* more pervasive than it needs to be, but thats a different patch :-). There are a set of routines in there like

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-09 Thread Jeff Law
On 07/09/2015 11:06 AM, Andrew MacLeod wrote: On 07/08/2015 10:42 PM, Andrew MacLeod wrote: On 07/08/2015 06:43 PM, Jeff Law wrote: predict.h is actually required by gimple.h for a few reasons, enum be_predictor is used in parameter lists and a few inlines use the TAKEN, NOT_TAKEN macros Its

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-08 Thread Andrew MacLeod
On 07/08/2015 06:43 PM, Jeff Law wrote: On 07/07/2015 05:53 PM, Andrew MacLeod wrote: yes, with a bit of tweaking and enhancement they can be generally useful. They are all in python. And no one is allowed to make comments like OMG thats so inefficient or what a horrible way to do that :-)

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-08 Thread Jeff Law
On 07/07/2015 05:53 PM, Andrew MacLeod wrote: yes, with a bit of tweaking and enhancement they can be generally useful. They are all in python. And no one is allowed to make comments like OMG thats so inefficient or what a horrible way to do that :-) My goal was getting things done and

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-07 Thread Jeff Law
On 07/07/2015 07:40 AM, Andrew MacLeod wrote: This is a series of 9 patches which does some flattening, some module building, and some basic cleanups. I am presenting them as 9 patches for easier review. The latter couple of patches affect a lot of the same files that follow on patches then

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-07 Thread Andrew MacLeod
On 07/07/2015 06:21 PM, Jeff Law wrote: On 07/07/2015 07:40 AM, Andrew MacLeod wrote: I can adjust any of this quite easily, or present them in a different way if you don't like it this way. Again, my goal is to check in just the final patch which does all the work of first 8 patches. It

[patch 0/9] Flattening and initial module rebuilding

2015-07-07 Thread Andrew MacLeod
This is a series of 9 patches which does some flattening, some module building, and some basic cleanups. I am presenting them as 9 patches for easier review. The latter couple of patches affect a lot of the same files that follow on patches then adjust, I've decided NOT to put the automated