Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-26 Thread Maxim Kuvyrkov
> On Feb 26, 2015, at 1:12 PM, Kyrill Tkachov wrote: > > ... > I've tried this patch out and added: > (automata_option "v") > (automata_option "time") > (automata_option "stats") > (automata_option "progress") > > to the .md file to get some compiler build-time stats on the automata. > I see t

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-26 Thread Kyrill Tkachov
Hi Xingxing, Some comments inline on the tuning struct and pipeline description. On 25/02/15 13:32, Xingxing Pan wrote: > Hi, > > This patch merges pipeline description for marvell-whitney to latest code base. > Is it OK for trunk? > > -- Regards, Xingxing > whitney_p1_20150225.patch A couple o

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-26 Thread Ramana Radhakrishnan
On Thu, Dec 18, 2014 at 10:13 AM, Xingxing Pan wrote: > Hi, > > This patch contains Marvell Whitney core's pipeline description. > Test on arm-linux-gnueabi and no new regression are found. > > Is it OK for trunk? I haven't had a chance to review this in detail but I think it's too late to add su

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-26 Thread Maxim Kuvyrkov
> On Feb 26, 2015, at 10:36 AM, Xingxing Pan wrote: > > On 02/25/2015 09:32 PM, Xingxing Pan wrote: >> Hi, >> >> This patch merges pipeline description for marvell-whitney to latest >> code base. >> Is it OK for trunk? >> > Refactor the commit message. > ... > Add pipeline description for ma

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-25 Thread Xingxing Pan
On 02/25/2015 09:32 PM, Xingxing Pan wrote: Hi, This patch merges pipeline description for marvell-whitney to latest code base. Is it OK for trunk? Refactor the commit message. -- Regards, Xingxing Add pipeline description for marvell-whitney. 2015-02-26 Xingxing Pan * config/arm/arm

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-02-25 Thread Xingxing Pan
Hi, This patch merges pipeline description for marvell-whitney to latest code base. Is it OK for trunk? -- Regards, Xingxing commit 83974dde8d9f773df1004aa1d5e3b05d8a33f5e0 Author: Xingxing Pan Date: Wed Feb 25 10:24:40 2015 +0800 2015-02-25 Xingxing Pan * config/arm/arm-c

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-01-13 Thread Xingxing Pan
On 09/01/2015 19:22, Kyrill Tkachov wrote: Hi Xingxing, On 19/12/14 11:01, Xingxing Pan wrote: +/* Return true if vector element size is byte. */ Minor nit: two spaces after full stop and before */ Same in other places in the patch. +bool +marvell_whitney_vector_element_size_is_byte (rtx ins

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2015-01-09 Thread Kyrill Tkachov
Hi Xingxing, On 19/12/14 11:01, Xingxing Pan wrote: +/* Return true if vector element size is byte. */ Minor nit: two spaces after full stop and before */ Same in other places in the patch. +bool +marvell_whitney_vector_element_size_is_byte (rtx insn) +{ + if (GET_CODE (PATTERN (insn)) == S

Re: [PING][patch 1/2][ARM]: New CPU support for Marvell Whitney

2014-12-22 Thread Xingxing Pan
On 19/12/2014 19:01, Xingxing Pan wrote: On 19/12/2014 18:38, Kyrill Tkachov wrote: Hi Xingxin, It seems that your mail client mangled this patch, at least the following hunk doesn't apply, even when I try to get it from the web archives. Could you please resend it as an attachment perhaps? Th

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread Xingxing Pan
On 19/12/2014 18:38, Kyrill Tkachov wrote: Hi Xingxin, It seems that your mail client mangled this patch, at least the following hunk doesn't apply, even when I try to get it from the web archives. Could you please resend it as an attachment perhaps? Thanks, Kyrill On 18/12/14 10:13, Xingxing

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread Kyrill Tkachov
Hi Xingxin, It seems that your mail client mangled this patch, at least the following hunk doesn't apply, even when I try to get it from the web archives. Could you please resend it as an attachment perhaps? Thanks, Kyrill On 18/12/14 10:13, Xingxing Pan wrote: diff --git a/gcc/config/arm/a

Re: [patch 1/2][ARM]: New CPU support for Marvell Whitney

2014-12-19 Thread Kyrill Tkachov
Hi Xingxing, On 18/12/14 10:13, Xingxing Pan wrote: + +(define_attr "tune_marvell_whitney" "yes,no" + (const (if_then_else (eq_attr "tune" "marvell_whitney") + (const_string "yes") + (const_string "no" Why do you need this? The canonical way we

[patch 1/2][ARM]: New CPU support for Marvell Whitney

2014-12-18 Thread Xingxing Pan
Hi, This patch contains Marvell Whitney core's pipeline description. Test on arm-linux-gnueabi and no new regression are found. Is it OK for trunk? Regards, Xingxing 2014-12-18 Xingxing Pan * config/arm/arm-cores.def: Add new core marvell-whitney. * config/arm/arm-pro