Re: [patch 1/3] Flatten gimple.h - go front end changes

2013-11-22 Thread Andrew MacLeod
On 11/21/2013 02:31 PM, Jeff Law wrote: On 11/21/13 11:15, Andrew MacLeod wrote: This bootstraps on x86_64-unknown-linux-gnu, and regressions are currently running. Assuming it passes fine, OK? patch#1 in the series is fine too. Checked in as revision 205272. Ian, here is the go

Re: [patch 1/3] Flatten gimple.h - go front end changes

2013-11-22 Thread Ian Lance Taylor
On Fri, Nov 22, 2013 at 8:02 AM, Andrew MacLeod amacl...@redhat.com wrote: On 11/21/2013 02:31 PM, Jeff Law wrote: On 11/21/13 11:15, Andrew MacLeod wrote: This bootstraps on x86_64-unknown-linux-gnu, and regressions are currently running. Assuming it passes fine, OK? patch#1 in the

Re: [patch 1/3] Flatten gimple.h

2013-11-21 Thread Andrew MacLeod
On 11/21/2013 03:07 PM, Jeff Law wrote: On 11/21/13 13:04, Andrew MacLeod wrote: On 11/21/2013 02:26 PM, Jeff Law wrote: On 11/21/13 11:15, Andrew MacLeod wrote: Is there anything in particular one needs to do for plugins? I thought I saw a patch somewhere that changed something in the

Plugin headers (was Re: [patch 1/3] Flatten gimple.h)

2013-11-21 Thread David Malcolm
On Thu, 2013-11-21 at 13:07 -0700, Jeff Law wrote: On 11/21/13 13:04, Andrew MacLeod wrote: On 11/21/2013 02:26 PM, Jeff Law wrote: On 11/21/13 11:15, Andrew MacLeod wrote: Is there anything in particular one needs to do for plugins? I thought I saw a patch somewhere that changed

Re: [patch 1/3] Flatten gimple.h

2013-11-21 Thread Jeff Law
On 11/21/13 13:04, Andrew MacLeod wrote: On 11/21/2013 02:26 PM, Jeff Law wrote: On 11/21/13 11:15, Andrew MacLeod wrote: Is there anything in particular one needs to do for plugins? I thought I saw a patch somewhere that changed something in the Makefile, but don't know if that is actually

[patch 1/3] Flatten gimple.h

2013-11-21 Thread Andrew MacLeod
The final gimple re-org patch! These patches move the #includes out of gimple.h and into the .c files which include gimple.h. They are: #include pointer-set.h #include hash-table.h #include vec.h #include ggc.h #include basic-block.h #include tree-ssa-alias.h #include internal-fn.h #include

Re: [patch 1/3] Flatten gimple.h

2013-11-21 Thread Jeff Law
On 11/21/13 11:15, Andrew MacLeod wrote: Is there anything in particular one needs to do for plugins? I thought I saw a patch somewhere that changed something in the Makefile, but don't know if that is actually required since I never did that for any of the others. Any plugin which used

Re: [patch 1/3] Flatten gimple.h

2013-11-21 Thread Eric Botcazou
I moved recalculate_side_effects() from gimple.c to gimplify.c. gimplify.c was the primary consumer, and the only other caller was in the ada front end. By moving it, the ada front end doesn't need gimple.h any more. Let's eliminate the only use in the Ada front end then, we probably just

Re: [patch 1/3] Flatten gimple.h

2013-11-21 Thread Diego Novillo
On Thu, Nov 21, 2013 at 3:04 PM, Andrew MacLeod amacl...@redhat.com wrote: On 11/21/2013 02:26 PM, Jeff Law wrote: On 11/21/13 11:15, Andrew MacLeod wrote: Is there anything in particular one needs to do for plugins? I thought I saw a patch somewhere that changed something in the Makefile,

Re: [patch 1/3] Flatten gimple.h

2013-11-21 Thread Andrew MacLeod
On 11/21/2013 02:26 PM, Jeff Law wrote: On 11/21/13 11:15, Andrew MacLeod wrote: Is there anything in particular one needs to do for plugins? I thought I saw a patch somewhere that changed something in the Makefile, but don't know if that is actually required since I never did that for any of