Re: [ping] account for register spans in expand_builtin_init_dwarf_reg_sizes

2014-12-05 Thread Olivier Hainque
On Dec 4, 2014, at 23:14 , Jason Merrill wrote: > On 11/24/2014 03:08 AM, Olivier Hainque wrote: >> + if (init_state->processed_regno[regno]) >> +return; > > I would expect this to go in the loop in expand_builtin_init_dwarf_reg_sizes, > before we look up a span for the regno. Sure. >

Re: [ping] account for register spans in expand_builtin_init_dwarf_reg_sizes

2014-12-04 Thread Jason Merrill
On 11/24/2014 03:08 AM, Olivier Hainque wrote: + if (init_state->processed_regno[regno]) +return; I would expect this to go in the loop in expand_builtin_init_dwarf_reg_sizes, before we look up a span for the regno. OK with that change. Jason

[ping] account for register spans in expand_builtin_init_dwarf_reg_sizes

2014-12-04 Thread Olivier Hainque
Hi Jason, ping for https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02975.html, a proposal to address comments you made on a patch I had sent earlier on. > The attached patches combined bootstrap and regtest fine on x86_64-linux. > We also have nominal test results with our 4.9 based series of comp

Re: [ping] account for register spans in expand_builtin_init_dwarf_reg_sizes

2014-11-24 Thread Olivier Hainque
On Nov 18, 2014, at 16:21 , Olivier Hainque wrote: > On Nov 18, 2014, at 03:29 , Jason Merrill wrote: >> What happens when the outer loop hits a register that we've already seen as >> part of a span? > I have a candidate improvement to prevent processing the same regno > multiple times. > > W

Re: [ping] account for register spans in expand_builtin_init_dwarf_reg_sizes

2014-11-18 Thread Olivier Hainque
On Nov 18, 2014, at 03:29 , Jason Merrill wrote: > What happens when the outer loop hits a register that we've already seen as > part of a span? Hmm, I was under the impression that this was supposed never to happen. I can see that this is not so clear though. What would happen with the cur

Re: [ping] account for register spans in expand_builtin_init_dwarf_reg_sizes

2014-11-17 Thread Jason Merrill
On 10/15/2014 11:07 AM, Olivier Hainque wrote: for (i = 0; i < FIRST_PSEUDO_REGISTER; i++) { + enum machine_mode save_mode = targetm.dwarf_frame_reg_mode (i); + rtx span; + span = targetm.dwarf_register_span (gen_rtx_REG (save_mode, i)); + if (!span) + init_one_

[ping] account for register spans in expand_builtin_init_dwarf_reg_sizes

2014-10-15 Thread Olivier Hainque
Hello, ping for https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02625.html a patch proposal to fix exception propagation on spe powerpc targets. The idea is to improve expand_builtin_init_dwarf_reg_sizes to account for register spans as other functions in dwarf2cfi.c do, by extracting the processi