Re: [testsuite] Fix multiple definitions of _init

2014-12-16 Thread Oleg Endo
On Mon, 2014-12-08 at 14:51 +0900, Kaz Kojima wrote: Oleg Endo oleg.e...@t-online.de wrote: Kaz, could you please check if the patch doesn't break anything on sh4-linux? If so, I'd like to commit this to trunk. Build and test ok on sh4-unknown-linux-gnu. Now also tested here with make

Re: [testsuite] Fix multiple definitions of _init

2014-12-07 Thread Oleg Endo
On Tue, 2014-12-02 at 10:23 -0800, Mike Stump wrote: No. It is reasonable for the test suite to fail when the implementation of gcc is wrong (unclean) or newlib startup code is wrong (unclean). Since that is what happened, the fix is to fix the cleanliness problem. I’ve read through the

Re: [testsuite] Fix multiple definitions of _init

2014-12-07 Thread Kaz Kojima
Oleg Endo oleg.e...@t-online.de wrote: Kaz, could you please check if the patch doesn't break anything on sh4-linux? If so, I'd like to commit this to trunk. Build and test ok on sh4-unknown-linux-gnu. Regards, kaz

Re: [testsuite] Fix multiple definitions of _init

2014-12-02 Thread Richard Biener
On Mon, Dec 1, 2014 at 11:48 PM, Oleg Endo oleg.e...@t-online.de wrote: On Mon, 2014-12-01 at 12:09 +0100, Richard Biener wrote: On Mon, Dec 1, 2014 at 8:21 AM, Oleg Endo oleg.e...@t-online.de wrote: Hi, When running the testsuite on a sh-elf configuration, some test cases fail due to

Re: [testsuite] Fix multiple definitions of _init

2014-12-02 Thread Oleg Endo
On Tue, 2014-12-02 at 11:22 +0100, Richard Biener wrote: On Mon, Dec 1, 2014 at 11:48 PM, Oleg Endo oleg.e...@t-online.de wrote: On Mon, 2014-12-01 at 12:09 +0100, Richard Biener wrote: On Mon, Dec 1, 2014 at 8:21 AM, Oleg Endo oleg.e...@t-online.de wrote: Hi, When running the

Re: [testsuite] Fix multiple definitions of _init

2014-12-02 Thread Mike Stump
On Nov 30, 2014, at 11:21 PM, Oleg Endo oleg.e...@t-online.de wrote: When running the testsuite on a sh-elf configuration, some test cases fail due to multiple definitions of the function '_init'. This is because on sh-elf every function is automatically prefixed with a '_' char. When

Re: [testsuite] Fix multiple definitions of _init

2014-12-02 Thread Joseph Myers
On Tue, 2 Dec 2014, Richard Biener wrote: Joseph may have more experience with how targets should setup USER_LABEL_PREFIX to avoid this situation. See e.g. config/arm/lib1funcs.S: #define SYM(x) CONCAT1 (__USER_LABEL_PREFIX__, x) (and the associated macro definition of CONCAT1 that uses,

Re: [testsuite] Fix multiple definitions of _init

2014-12-01 Thread Richard Biener
On Mon, Dec 1, 2014 at 8:21 AM, Oleg Endo oleg.e...@t-online.de wrote: Hi, When running the testsuite on a sh-elf configuration, some test cases fail due to multiple definitions of the function '_init'. This is because on sh-elf every function is automatically prefixed with a '_' char.

Re: [testsuite] Fix multiple definitions of _init

2014-12-01 Thread Oleg Endo
On Mon, 2014-12-01 at 12:09 +0100, Richard Biener wrote: On Mon, Dec 1, 2014 at 8:21 AM, Oleg Endo oleg.e...@t-online.de wrote: Hi, When running the testsuite on a sh-elf configuration, some test cases fail due to multiple definitions of the function '_init'. This is because on sh-elf

[testsuite] Fix multiple definitions of _init

2014-11-30 Thread Oleg Endo
Hi, When running the testsuite on a sh-elf configuration, some test cases fail due to multiple definitions of the function '_init'. This is because on sh-elf every function is automatically prefixed with a '_' char. When defining a C function 'init' in some code, the actual name becomes '_init'