Re: [v2 of PATCH 06/14] Strip location wrappers in operand_equal_p

2017-12-19 Thread Jakub Jelinek
On Tue, Dec 19, 2017 at 04:59:34PM -0500, Jason Merrill wrote: > > Or do you mean it should strip just the special VIEW_CONVERT_EXPR > > that has type identical to the operand's type? > > That; interpreting something as the same type seems like a nop. Ok, that makes sense. Jakub

Re: [v2 of PATCH 06/14] Strip location wrappers in operand_equal_p

2017-12-19 Thread Jason Merrill
On Tue, Dec 19, 2017 at 3:49 PM, Jakub Jelinek wrote: > On Tue, Dec 19, 2017 at 03:13:13PM -0500, Jason Merrill wrote: >> On 12/17/2017 09:07 PM, David Malcolm wrote: >> > On Mon, 2017-12-11 at 18:37 -0500, Jason Merrill wrote: >> > > On 11/10/2017 04:45 PM, David Malcolm wrote: >> > > > gcc/c-fam

Re: [v2 of PATCH 06/14] Strip location wrappers in operand_equal_p

2017-12-19 Thread Jakub Jelinek
On Tue, Dec 19, 2017 at 03:13:13PM -0500, Jason Merrill wrote: > On 12/17/2017 09:07 PM, David Malcolm wrote: > > On Mon, 2017-12-11 at 18:37 -0500, Jason Merrill wrote: > > > On 11/10/2017 04:45 PM, David Malcolm wrote: > > > > gcc/c-family/ChangeLog: > > > > * c-warn.c (sizeof_pointer_mem

Re: [v2 of PATCH 06/14] Strip location wrappers in operand_equal_p

2017-12-19 Thread Jason Merrill
On 12/17/2017 09:07 PM, David Malcolm wrote: On Mon, 2017-12-11 at 18:37 -0500, Jason Merrill wrote: On 11/10/2017 04:45 PM, David Malcolm wrote: gcc/c-family/ChangeLog: * c-warn.c (sizeof_pointer_memaccess_warning): Strip any location wrappers from src and dest. Here the exis

Re: [v2 of PATCH 06/14] Strip location wrappers in operand_equal_p

2017-12-18 Thread Jakub Jelinek
On Sun, Dec 17, 2017 at 09:07:54PM -0500, David Malcolm wrote: > What do you think? > > Successfully bootstrapped®rtested on x86_64-pc-linux-gnu, as > part of the kit. > > gcc/ChangeLog: > * fold-const.c (operand_equal_p): Strip any location wrappers, > before computing hashes. > ---

[v2 of PATCH 06/14] Strip location wrappers in operand_equal_p

2017-12-17 Thread David Malcolm
On Mon, 2017-12-11 at 18:37 -0500, Jason Merrill wrote: > On 11/10/2017 04:45 PM, David Malcolm wrote: > > gcc/c-family/ChangeLog: > > * c-warn.c (sizeof_pointer_memaccess_warning): Strip any > > location > > wrappers from src and dest. > > Here the existing calls to tree_strip_nop_convers