Re: Re: Re: [PATCH, rs6000] Add command line and builtin compatibility

2020-03-20 Thread Segher Boessenkool
Hi! On Thu, Mar 19, 2020 at 07:46:53PM -0500, Segher Boessenkool wrote: > Please make such changes if you agree. Either way, okay for trunk. Oh, and okay for backport to 9 next week :-) Segher

Re: Re: Re: [PATCH, rs6000] Add command line and builtin compatibility

2020-03-19 Thread Segher Boessenkool
Hi Carl, On Wed, Mar 18, 2020 at 04:19:18PM -0700, Carl Love wrote: > > Yes, but only for this fprnd vs. 2.06 (vsx) situation. Like we > > already > > have: > > > > if (TARGET_DIRECT_MOVE && !TARGET_VSX) > > { > > if (rs6000_isa_flags_explicit & OPTION_MASK_DIRECT_MOVE) > >

Re: Re: Re: [PATCH, rs6000] Add command line and builtin compatibility

2020-03-18 Thread Carl Love via Gcc-patches
Segher: > > Yes, but only for this fprnd vs. 2.06 (vsx) situation. Like we > already > have: > > if (TARGET_DIRECT_MOVE && !TARGET_VSX) > { > if (rs6000_isa_flags_explicit & OPTION_MASK_DIRECT_MOVE) > error ("%qs requires %qs", "-mdirect-move", "-mvsx"); >

Re: Re: [PATCH,rs6000] Add command line and builtin compatibility

2020-03-12 Thread Segher Boessenkool
Hi Carl, On Thu, Mar 12, 2020 at 09:57:06AM -0700, Carl Love wrote: > > From the GCC manual: > > > > -mmfcrfp4 2.01 > > -mpopcntb p5 2.02 > > -mfprndp5+ 2.04 ("info gcc" says 2.03, that's wrong? But the > > ISA > > says this is 2.02 even? Now what!) >

Re: Re: [PATCH,rs6000] Add command line and builtin compatibility

2020-03-12 Thread Carl Love via Gcc-patches
Segher: > > From the GCC manual: > > -mmfcrfp4 2.01 > -mpopcntb p5 2.02 > -mfprndp5+ 2.04 ("info gcc" says 2.03, that's wrong? But the > ISA > says this is 2.02 even? Now what!) > -mcmpb p6 2.05 > -mpopcntd p7 2.06 > > (and there are more,

Re: [PATCH,rs6000] Add command line and builtin compatibility

2020-03-11 Thread Segher Boessenkool
On Wed, Mar 11, 2020 at 02:12:59PM -0500, Bill Schmidt wrote: > >+ error ("%s is incompatible with mno-fprnd option", > > I believe you need %qs here.  Also replace mno-fprnd with %qs and put > "-mno-fprnd" as the associated parameter. > > Example from nearby code:   error ("%qs requires

Re: [PATCH,rs6000] Add command line and builtin compatibility

2020-03-11 Thread Segher Boessenkool
Hi! On Wed, Mar 11, 2020 at 12:00:12PM -0700, Carl Love wrote: > The following patch add a check to make sure the user did not specify > -mno_fprnd with the builtins __builtin_vsx_xsrdpim and > __builtin_vsx_xsrdpip. These builtins are incompatible with the > -mno_fprnd command line. The

Re: [PATCH,rs6000] Add command line and builtin compatibility

2020-03-11 Thread Carl Love via Gcc-patches
Bill: On Wed, 2020-03-11 at 14:12 -0500, Bill Schmidt wrote: > I believe you need %qs here. Also replace mno-fprnd with %qs and > put > "-mno-fprnd" as the associated parameter. > > Example from nearby code: error ("%qs requires %qs", "-mdirect- > move", > "-mvsx"); Yes. I had originally

Re: [PATCH,rs6000] Add command line and builtin compatibility

2020-03-11 Thread Bill Schmidt via Gcc-patches
On 3/11/20 2:00 PM, Carl Love wrote: GCC maintianers: The following patch add a check to make sure the user did not specify -mno_fprnd with the builtins __builtin_vsx_xsrdpim and __builtin_vsx_xsrdpip. These builtins are incompatible with the -mno_fprnd command line. The check prevents GCC