Re: Add optabs for common types of permutation

2017-11-23 Thread Richard Sandiford
Jakub Jelinek writes: > On Thu, Nov 23, 2017 at 02:43:32PM +0100, Michael Matz wrote: >> > If it's a VEC_PERM_EXPR then it'll be a new form of VEC_PERM_EXPR. >> >> No, it'd be a VEC_PERM_EXPR where the magic mask is generated by a new >> EXPR type, instead of being a mere constant. > > Or an int

Re: Add optabs for common types of permutation

2017-11-23 Thread Richard Sandiford
Michael Matz writes: > Hi, > > On Thu, 23 Nov 2017, Richard Sandiford wrote: > >> > I don't want variable-size vector special-casing everywhere. I want >> > it to be somehow naturally integrating with existing stuff. >> >> It's going to be a special case whatever happens though. > > It wouldn't

Re: Add optabs for common types of permutation

2017-11-23 Thread Jakub Jelinek
On Thu, Nov 23, 2017 at 02:43:32PM +0100, Michael Matz wrote: > > If it's a VEC_PERM_EXPR then it'll be a new form of VEC_PERM_EXPR. > > No, it'd be a VEC_PERM_EXPR where the magic mask is generated by a new > EXPR type, instead of being a mere constant. Or an internal function that would produc

Re: Add optabs for common types of permutation

2017-11-23 Thread Michael Matz
Hi, On Thu, 23 Nov 2017, Richard Sandiford wrote: > > I don't want variable-size vector special-casing everywhere. I want > > it to be somehow naturally integrating with existing stuff. > > It's going to be a special case whatever happens though. It wouldn't have to be this way. It's like sa

Re: Add optabs for common types of permutation

2017-11-23 Thread Richard Sandiford
Richard Biener writes: > On Tue, Nov 21, 2017 at 11:47 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Mon, Nov 20, 2017 at 1:35 PM, Richard Sandiford >>> wrote: Richard Biener writes: > On Mon, Nov 20, 2017 at 12:56 AM, Jeff Law wrote: >> On 11/09/2017 06:24 AM,

Re: Add optabs for common types of permutation

2017-11-23 Thread Richard Biener
On Tue, Nov 21, 2017 at 11:47 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Nov 20, 2017 at 1:35 PM, Richard Sandiford >> wrote: >>> Richard Biener writes: On Mon, Nov 20, 2017 at 12:56 AM, Jeff Law wrote: > On 11/09/2017 06:24 AM, Richard Sandiford wrote: >> ..

Re: Add optabs for common types of permutation

2017-11-21 Thread Richard Sandiford
Richard Biener writes: > On Mon, Nov 20, 2017 at 1:35 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Mon, Nov 20, 2017 at 12:56 AM, Jeff Law wrote: On 11/09/2017 06:24 AM, Richard Sandiford wrote: > ...so that we can use them for variable-length vectors. For now >

Re: Add optabs for common types of permutation

2017-11-21 Thread Richard Biener
On Mon, Nov 20, 2017 at 1:35 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Nov 20, 2017 at 12:56 AM, Jeff Law wrote: >>> On 11/09/2017 06:24 AM, Richard Sandiford wrote: ...so that we can use them for variable-length vectors. For now constant-length vectors continue

Re: Add optabs for common types of permutation

2017-11-20 Thread Richard Sandiford
Richard Biener writes: > On Mon, Nov 20, 2017 at 12:56 AM, Jeff Law wrote: >> On 11/09/2017 06:24 AM, Richard Sandiford wrote: >>> ...so that we can use them for variable-length vectors. For now >>> constant-length vectors continue to use VEC_PERM_EXPR and the >>> vec_perm_const optab even for c

Re: Add optabs for common types of permutation

2017-11-20 Thread Richard Biener
On Mon, Nov 20, 2017 at 12:56 AM, Jeff Law wrote: > On 11/09/2017 06:24 AM, Richard Sandiford wrote: >> ...so that we can use them for variable-length vectors. For now >> constant-length vectors continue to use VEC_PERM_EXPR and the >> vec_perm_const optab even for cases that the new optabs could

Re: Add optabs for common types of permutation

2017-11-19 Thread Jeff Law
On 11/09/2017 06:24 AM, Richard Sandiford wrote: > ...so that we can use them for variable-length vectors. For now > constant-length vectors continue to use VEC_PERM_EXPR and the > vec_perm_const optab even for cases that the new optabs could > handle. > > The vector optabs are inconsistent about

Add optabs for common types of permutation

2017-11-09 Thread Richard Sandiford
...so that we can use them for variable-length vectors. For now constant-length vectors continue to use VEC_PERM_EXPR and the vec_perm_const optab even for cases that the new optabs could handle. The vector optabs are inconsistent about whether there should be an underscore before the mode part o