Re: Backported r185231 from trunk. (issue 6878045)

2012-12-05 Thread xur
Look good to me. Please check with David if google-main branch is currently opened for check-in. -Rong https://codereview.appspot.com/6878045/

Re: Backported r185231 from trunk. (issue 6878045)

2012-12-05 Thread Xinliang David Li
It (a trunk backport) is not needed for google/main. David On Wed, Dec 5, 2012 at 1:46 PM, x...@google.com wrote: Look good to me. Please check with David if google-main branch is currently opened for check-in. -Rong https://codereview.appspot.com/6878045/

Backported r185231 from trunk. (issue 6878045)

2012-12-03 Thread asharif
Reviewers: davidxl, xur, Message: When I backported this patch to google/gcc-4.6, I forgot to do it for main. So now I am backporting this to google/main, google/4_7 and google/4_7-mobile. This is the first of the 3 (google/main is the target). I am running crosstool_validate.py and it should

Re: Backported r185231 from trunk. (issue 6878045)

2012-12-03 Thread asharif
On 2012/12/04 00:50:45, asharif wrote: When I backported this patch to google/gcc-4.6, I forgot to do it for main. So now I am backporting this to google/main, google/4_7 and google/4_7-mobile. This is the first of the 3 (google/main is the target). I am running crosstool_validate.py and

Re: Backported r185231 from trunk. (issue 6878045)

2012-12-03 Thread Xinliang David Li
Looks good for gcc-4_7* branches. There is no need to port any trunk changes to google/main (it will be synced to trunk at some point). David On Mon, Dec 3, 2012 at 4:50 PM, asha...@chromium.org wrote: Reviewers: davidxl, xur, Message: When I backported this patch to google/gcc-4.6, I