Re: C++ PATCH for c++/48113 (SFINAE bug causing bind regression in libstdc++)

2011-03-17 Thread Jakub Jelinek
On Thu, Mar 17, 2011 at 09:26:36AM +0100, Richard Guenther wrote: > Ok for 4.6.0. I guess we need to do a RC2 anyway. Yeah, certainly. I'll roll one during the weekend, it would be nice if all the pending fixes still desirable for 4.6.0 make it till then and after RC2 we'd try to allow only very

Re: C++ PATCH for c++/48113 (SFINAE bug causing bind regression in libstdc++)

2011-03-17 Thread Richard Guenther
On Wed, Mar 16, 2011 at 8:51 PM, Jason Merrill wrote: > convert_for_initialization is sfinae-enabled, but it was calling > ocp_convert, which is not.  This patch changes it to use the newer > perform_implicit_conversion_flags instead.  To make that work, I needed to > add support for LOOKUP_PREFER

Re: C++ PATCH for c++/48113 (SFINAE bug causing bind regression in libstdc++)

2011-03-16 Thread Paolo Carlini
Hi, > > Also OK for 4.6.0? The risk is that swapping to > perform_implicit_conversion_flags will have other differences of behavior, > but the library regression seems pretty major, so I think it's worth the risk. Thanks Jason. Indeed, I agree that the library issue is pretty serious. If you

C++ PATCH for c++/48113 (SFINAE bug causing bind regression in libstdc++)

2011-03-16 Thread Jason Merrill
convert_for_initialization is sfinae-enabled, but it was calling ocp_convert, which is not. This patch changes it to use the newer perform_implicit_conversion_flags instead. To make that work, I needed to add support for LOOKUP_PREFER_RVALUE to that code path. Tested x86_64-pc-linux-gnu, app