Re: C++ PATCH for c++/90825 - endless recursion when evaluating sizeof

2019-06-12 Thread Jason Merrill
On 6/11/19 3:59 PM, Marek Polacek wrote: On Tue, Jun 11, 2019 at 03:05:26PM -0400, Jason Merrill wrote: On 6/11/19 2:28 PM, Marek Polacek wrote: On Tue, Jun 11, 2019 at 08:37:27AM -0400, Jason Merrill wrote: On 6/11/19 7:47 AM, Jakub Jelinek wrote: On Mon, Jun 10, 2019 at 09:59:46PM -0400, Ma

Re: C++ PATCH for c++/90825 - endless recursion when evaluating sizeof

2019-06-11 Thread Marek Polacek
On Tue, Jun 11, 2019 at 03:05:26PM -0400, Jason Merrill wrote: > On 6/11/19 2:28 PM, Marek Polacek wrote: > > On Tue, Jun 11, 2019 at 08:37:27AM -0400, Jason Merrill wrote: > > > On 6/11/19 7:47 AM, Jakub Jelinek wrote: > > > > On Mon, Jun 10, 2019 at 09:59:46PM -0400, Marek Polacek wrote: > > > >

Re: C++ PATCH for c++/90825 - endless recursion when evaluating sizeof

2019-06-11 Thread Jason Merrill
On 6/11/19 2:28 PM, Marek Polacek wrote: On Tue, Jun 11, 2019 at 08:37:27AM -0400, Jason Merrill wrote: On 6/11/19 7:47 AM, Jakub Jelinek wrote: On Mon, Jun 10, 2019 at 09:59:46PM -0400, Marek Polacek wrote: This test segvs since r269078, this hunk in particular: @@ -4581,8 +4713,9 @@ cxx_eva

Re: C++ PATCH for c++/90825 - endless recursion when evaluating sizeof

2019-06-11 Thread Marek Polacek
On Tue, Jun 11, 2019 at 08:37:27AM -0400, Jason Merrill wrote: > On 6/11/19 7:47 AM, Jakub Jelinek wrote: > > On Mon, Jun 10, 2019 at 09:59:46PM -0400, Marek Polacek wrote: > > > This test segvs since r269078, this hunk in particular: > > > > > > @@ -4581,8 +4713,9 @@ cxx_eval_constant_expression

Re: C++ PATCH for c++/90825 - endless recursion when evaluating sizeof

2019-06-11 Thread Jason Merrill
On 6/11/19 7:47 AM, Jakub Jelinek wrote: On Mon, Jun 10, 2019 at 09:59:46PM -0400, Marek Polacek wrote: This test segvs since r269078, this hunk in particular: @@ -4581,8 +4713,9 @@ cxx_eval_constant_expression (const constexpr_ctx *ctx, tree t, break; case SIZEOF_EXPR: - r

Re: C++ PATCH for c++/90825 - endless recursion when evaluating sizeof

2019-06-11 Thread Jakub Jelinek
On Mon, Jun 10, 2019 at 09:59:46PM -0400, Marek Polacek wrote: > This test segvs since r269078, this hunk in particular: > > @@ -4581,8 +4713,9 @@ cxx_eval_constant_expression (const constexpr_ctx *ctx, > tree t, >break; > > case SIZEOF_EXPR: > - r = fold_sizeof_expr (t); > -

C++ PATCH for c++/90825 - endless recursion when evaluating sizeof

2019-06-10 Thread Marek Polacek
This test segvs since r269078, this hunk in particular: @@ -4581,8 +4713,9 @@ cxx_eval_constant_expression (const constexpr_ctx *ctx, tree t, break; case SIZEOF_EXPR: - r = fold_sizeof_expr (t); - VERIFY_CONSTANT (r); + r = cxx_eval_constant_expression (ctx, fold_sizeo