Re: C++ PATCH to support non-constexpr variable templates

2014-08-25 Thread Jason Merrill
On 08/25/2014 03:15 PM, Ville Voutilainen wrote: Another ICE Fixed: Jason commit 351ac0a147cbfe01e4f8b13a79432d3f37f42caa Author: Jason Merrill Date: Mon Aug 25 20:29:21 2014 -0400 * pt.c (check_explicit_specialization): Don't complain about non-template variable. (templat

Re: C++ PATCH to support non-constexpr variable templates

2014-08-25 Thread Jason Merrill
On 08/25/2014 03:15 PM, Ville Voutilainen wrote: should we just add these test-for-valid cases as new tests? Or should they become bug reports instead? Please advise how to best handle these. Bug reports, please. Or perhaps multiple testcases on one bug report, for now. :) Jason

Re: C++ PATCH to support non-constexpr variable templates

2014-08-25 Thread Ville Voutilainen
On 25 August 2014 17:08, wrote: >> Anyway, here's a fix for your recent test. > > Thanks, I'll take a look at the tests and will send a patch if something > seems missing; static member variable templates of a class template and > explicit specializations thereof are the likely starting point.

Re: C++ PATCH to support non-constexpr variable templates

2014-08-25 Thread ville . voutilainen
On Mon Aug 25 2014 15:47:26 GMT+0300 (EEST), Jason Merrill wrote: > On 08/25/2014 05:24 AM, Ville Voutilainen wrote: > > Well, it's a bit premature to add tests when the implementation itself is > > not > > quite complete, I guess. :) Having ICEs makes it hard to add tests, too. :P > > But test

Re: C++ PATCH to support non-constexpr variable templates

2014-08-25 Thread Jason Merrill
On 08/25/2014 05:24 AM, Ville Voutilainen wrote: Well, it's a bit premature to add tests when the implementation itself is not quite complete, I guess. :) Having ICEs makes it hard to add tests, too. :P But tests are how you verify that the implementation is complete. Anyway, here's a fix for

Re: C++ PATCH to support non-constexpr variable templates

2014-08-25 Thread Ville Voutilainen
On 25 August 2014 05:54, Jason Merrill wrote: > On 08/23/2014 06:29 PM, Ville Voutilainen wrote: >> >> Based on my quick tests with it, it seems to me that we need more >> tests for static member variable templates. My first attempt at something >> like that gave an ICE... > > > Yeah, I figured th

Re: C++ PATCH to support non-constexpr variable templates

2014-08-24 Thread Jason Merrill
On 08/23/2014 06:29 PM, Ville Voutilainen wrote: Based on my quick tests with it, it seems to me that we need more tests for static member variable templates. My first attempt at something like that gave an ICE... Yeah, I figured there would be more to do. More tests are welcome. :) Jason

Re: C++ PATCH to support non-constexpr variable templates

2014-08-23 Thread Ville Voutilainen
Based on my quick tests with it, it seems to me that we need more tests for static member variable templates. My first attempt at something like that gave an ICE...

C++ PATCH to support non-constexpr variable templates

2014-08-22 Thread Jason Merrill
Since nobody else seemed to be working on finishing up variable template support, I've gone ahead and done it. There were only a few tweaks needed. For the pr59638.C issue, I'm throwing away the implicit template parameter list before we call start_decl so we don't actually create an implicit