Hi!
On Wed, 19 Oct 2016 12:28:39 +0200, I wrote:
> [PR tree-optimization/78024] Clear basic block flags before using
> BB_VISITED for OpenACC loops processing
To fix the same problem, committed the following to gcc-6-branch in
r244264:
commit 82f25a52380b366a99af8045fb615d79d4ff94b6
4b1ac65df70d98f7e7557a27947948c1
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Wed Oct 19 10:19:24 2016 +
[PR tree-optimization/78024] Clear basic block flags before using
BB_VISITED for OpenACC loops processing
gcc/
* omp-low.c (oac
t this pattern will need to be adjusted if changing the
>> OpenACC loop processing.
>>
>> > > This won't generally cause any problem
>> > > (apart from performance regression, obviously); it just caused problems
>> > > in a few libgomp test cases that
> parallelized execution -- which will/did trigger only with nvptx
> > > offloading enabled, which not too many people are testing. The test case
> > > I propose below will trigger also for non-offloading configurations.
>
> On IRC, Segher suggested to 'use {} instead
ally cause any problem
> > (apart from performance regression, obviously); it just caused problems
> > in a few libgomp test cases that actually at run time test for
> > parallelized execution -- which will/did trigger only with nvptx
> > offloading enabled, which not too many people are testing. The test case
&g
u can scan for "loop parallelized" instead? I fear your pattern
is quite fragile
to maintain over time.
Richard.
> This won't generally cause any problem
> (apart from performance regression, obviously); it just caused problems
> in a few libgomp test cases that actually
ror is "benign" such that the
OpenACC loop processing machinery will decide to not parallelize loops
that ought to be parallelized. This won't generally cause any problem
(apart from performance regression, obviously); it just caused problems
in a few libgomp test cases that actually at run
.
> commit 4e8abdfd25aa08abbad0c3fe2e9ec6182308f78c
> Author: Thomas Schwinge <tho...@codesourcery.com>
> Date: Mon Oct 17 11:29:43 2016 +0200
>
> Clear basic block flags before using BB_VISITED for OpenACC loops
> processing
>
> gcc/
> * omp-l
to commit the following? Is such a test case appropriate (which would
have caught this issue right away), in particular the dg-final
scan-tree-dump line?
commit 4e8abdfd25aa08abbad0c3fe2e9ec6182308f78c
Author: Thomas Schwinge <tho...@codesourcery.com>
Date: Mon Oct 17 11:29:43 2016 +0200