Re: Diagnostics from GCC_DRIVER_HOST_INITIALIZATION

2012-07-27 Thread Dodji Seketeli
Hello, Ryan Mansfield rmansfi...@qnx.com a écrit: On 12-07-19 06:06 PM, Gabriel Dos Reis wrote: [...] Would moving the GCC_DRIVER_HOST_INITIALIZATION after diagnostic_initialize be OK? yes, I think so. OK, then here's a changelog entry for the diff. 2012-07-20 Ryan Mansfield

Re: Diagnostics from GCC_DRIVER_HOST_INITIALIZATION

2012-07-27 Thread Ryan Mansfield
On 12-07-27 03:41 AM, Dodji Seketeli wrote: 2012-07-20 Ryan Mansfield rmansfi...@qnx.com * gcc.c (main): Move GCC_DRIVER_HOST_INITIALIZATION after diagnostic_initialize. Could someone please apply the change? The change seems small and obvious enough to not require

Re: Diagnostics from GCC_DRIVER_HOST_INITIALIZATION

2012-07-27 Thread Dodji Seketeli
Gabriel Dos Reis g...@integrable-solutions.net a écrit: 2012-07-20 Ryan Mansfield rmansfi...@qnx.com javascript:; * gcc.c (main): Move GCC_DRIVER_HOST_INITIALIZATION after diagnostic_initialize. Could someone please apply the change? The change seems small and

Re: Diagnostics from GCC_DRIVER_HOST_INITIALIZATION

2012-07-20 Thread Ryan Mansfield
On 12-07-19 06:06 PM, Gabriel Dos Reis wrote: On Thu, Jul 19, 2012 at 4:13 PM, Ryan Mansfield rmansfi...@qnx.com wrote: GCC_DRIVER_HOST_INITIALIZATION happens before diagnostic_initialize, this can cause crashes if it call diagnostics such as warning, or fatal_error are used in the macro. One

Diagnostics from GCC_DRIVER_HOST_INITIALIZATION

2012-07-19 Thread Ryan Mansfield
GCC_DRIVER_HOST_INITIALIZATION happens before diagnostic_initialize, this can cause crashes if it call diagnostics such as warning, or fatal_error are used in the macro. One example would be in darwin-driver.c where darwin_find_version_from_kernel can call warning(). Another example is in

Re: Diagnostics from GCC_DRIVER_HOST_INITIALIZATION

2012-07-19 Thread Gabriel Dos Reis
On Thu, Jul 19, 2012 at 4:13 PM, Ryan Mansfield rmansfi...@qnx.com wrote: GCC_DRIVER_HOST_INITIALIZATION happens before diagnostic_initialize, this can cause crashes if it call diagnostics such as warning, or fatal_error are used in the macro. One example would be in darwin-driver.c where