Re: FIx riscv port building with the trunk

2017-03-13 Thread Palmer Dabbelt
Thanks Kito -- this had broken my build too, I'd just gotten distracted by another bug and had forgotten to commit it. It's now in as commit 6ca48c85b40db96f01d49f37afb19100b4a6b75b Author: palmer Date: Tue Mar 14 03:51:24 2017 + Use gcc_fallthrough() instead of __attribute__((fallthr

Re: FIx riscv port building with the trunk

2017-03-13 Thread Kito Cheng
Hi Jeff: It's make older gcc version can't build RISC-V port, how about use gcc_fallthrough instead? diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c index f4c1f23..d1af07f5 100644 --- a/gcc/config/riscv/riscv.c +++ b/gcc/config/riscv/riscv.c @@ -2089,13 +2089,13 @@ riscv_emit_flo

Re: FIx riscv port building with the trunk

2017-03-13 Thread Palmer Dabbelt
On Mon, 13 Mar 2017 10:50:28 PDT (-0700), l...@redhat.com wrote: > > RISCV targets were failing to build due to implicit-fallthru warnings. > > This changes comments which indicated expected fallthru to use the > attribute and the port builds again. I assume something about the use > of the cpp m

FIx riscv port building with the trunk

2017-03-13 Thread Jeff Law
RISCV targets were failing to build due to implicit-fallthru warnings. This changes comments which indicated expected fallthru to use the attribute and the port builds again. I assume something about the use of the cpp macro is causing the comment to not have the intended effect. I didn't