Re: Fix Eh delivery in partitioned functions

2017-07-19 Thread Richard Biener
On Wed, 19 Jul 2017, Jan Hubicka wrote: > > Did you see the inline comments? > > I missed them, sorry :) > This is updated patch I am testing. Ok with adding + maybe_add_nop_after_section_switch (); in pass_convert_to_eh_region_ranges::execute instead. Richard. > Index: except.c >

Re: Fix Eh delivery in partitioned functions

2017-07-19 Thread Jan Hubicka
> Did you see the inline comments? I missed them, sorry :) This is updated patch I am testing. Index: except.c === --- except.c(revision 250312) +++ except.c(working copy) @@ -2444,6 +2444,61 @@ emit_note_eh_region_end

Re: Fix Eh delivery in partitioned functions

2017-07-19 Thread Richard Biener
On Wed, 19 Jul 2017, Jan Hubicka wrote: > > On Wed, 19 Jul 2017, Jan Hubicka wrote: > > > > > > > I think we could just output from generic code - I think it can be > > > > > done by > > > > > final_scan_insn. I don't know however if we have a way to tell if the > > > > > section > > > > >

Re: Fix Eh delivery in partitioned functions

2017-07-19 Thread Jan Hubicka
> On Wed, 19 Jul 2017, Jan Hubicka wrote: > > > > > I think we could just output from generic code - I think it can be done > > > > by > > > > final_scan_insn. I don't know however if we have a way to tell if the > > > > section > > > > starts with a landing pad? > > > > > > Not sure either --

Re: Fix Eh delivery in partitioned functions

2017-07-19 Thread Richard Biener
On Wed, 19 Jul 2017, Jan Hubicka wrote: > > > I think we could just output from generic code - I think it can be done by > > > final_scan_insn. I don't know however if we have a way to tell if the > > > section > > > starts with a landing pad? > > > > Not sure either -- some insn note / bb

Re: Fix Eh delivery in partitioned functions

2017-07-19 Thread Jan Hubicka
> > I think we could just output from generic code - I think it can be done by > > final_scan_insn. I don't know however if we have a way to tell if the > > section > > starts with a landing pad? > > Not sure either -- some insn note / bb note? Some flag on the label? > At least the latter

Re: Fix Eh delivery in partitioned functions

2017-07-18 Thread Richard Biener
On Tue, 18 Jul 2017, Jan Hubicka wrote: > > On Tue, 18 Jul 2017, Jan Hubicka wrote: > > > > > Hi, > > > this patch fixes wrong code issue with BB partitioning where sometimes EH > > > is not delivered. This is very old issue that affect all release branches > > > with -fprofile-use, but

Re: Fix Eh delivery in partitioned functions

2017-07-18 Thread Jan Hubicka
> On Tue, 18 Jul 2017, Jan Hubicka wrote: > > > Hi, > > this patch fixes wrong code issue with BB partitioning where sometimes EH > > is not delivered. This is very old issue that affect all release branches > > with -fprofile-use, but recently surfaced as libstdc++ testsuite regression > >

Re: Fix Eh delivery in partitioned functions

2017-07-18 Thread Richard Biener
On Tue, 18 Jul 2017, Jan Hubicka wrote: > Hi, > this patch fixes wrong code issue with BB partitioning where sometimes EH > is not delivered. This is very old issue that affect all release branches > with -fprofile-use, but recently surfaced as libstdc++ testsuite regression > because we now

Fix Eh delivery in partitioned functions

2017-07-18 Thread Jan Hubicka
Hi, this patch fixes wrong code issue with BB partitioning where sometimes EH is not delivered. This is very old issue that affect all release branches with -fprofile-use, but recently surfaced as libstdc++ testsuite regression because we now partition functions based on static profile