Re: Fix for PR70481 Libiberty Demangler

2016-03-31 Thread Jeff Law
On 03/31/2016 11:29 AM, Bernd Schmidt wrote: On 03/31/2016 07:22 PM, Jeff Law wrote: @@ -1237,11 +1237,13 @@ squangle_mop_up (struct work_stuff *work) Thanks. I've just installed this patch, along with suitable tests from 70481 and 67394. What are the rules for modifying libiberty again?

Re: Fix for PR70481 Libiberty Demangler

2016-03-31 Thread Bernd Schmidt
On 03/31/2016 07:22 PM, Jeff Law wrote: @@ -1237,11 +1237,13 @@ squangle_mop_up (struct work_stuff *work) Thanks. I've just installed this patch, along with suitable tests from 70481 and 67394. What are the rules for modifying libiberty again? Do we have to patch binutils/gdb at the same

Re: Fix for PR70481 Libiberty Demangler

2016-03-31 Thread Jeff Law
On 03/31/2016 08:55 AM, Marcel Böhme wrote: Hi, This fixes the use-after-free detailed in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70481 There is a variable ksize storing the amount of allocated memory for the array ktypevec. ksize being zero (0) indicates that some memory must be

Fix for PR70481 Libiberty Demangler

2016-03-31 Thread Marcel Böhme
Hi, This fixes the use-after-free detailed in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70481 There is a variable ksize storing the amount of allocated memory for the array ktypevec. ksize being zero (0) indicates that some memory must be allocated upon the first write. When more memory is