Re: Fix indirect call profiling for COMDAT symbols

2014-04-15 Thread Richard Biener
On Mon, 14 Apr 2014, Jakub Jelinek wrote: > On Mon, Apr 14, 2014 at 07:22:37PM +0200, Jan Hubicka wrote: > > > Hi, > > > while looking into firefox profiles, I noticed that we miss > > > devirtualizations > > > to comdat symbols, because we manage to get different profile_id in each > > > unit.

Re: Fix indirect call profiling for COMDAT symbols

2014-04-14 Thread Jakub Jelinek
On Mon, Apr 14, 2014 at 07:22:37PM +0200, Jan Hubicka wrote: > > Hi, > > while looking into firefox profiles, I noticed that we miss > > devirtualizations > > to comdat symbols, because we manage to get different profile_id in each > > unit. This is easily fixed by the following patch that makes

Re: Fix indirect call profiling for COMDAT symbols

2014-04-14 Thread Jan Hubicka
> Hi, > while looking into firefox profiles, I noticed that we miss devirtualizations > to comdat symbols, because we manage to get different profile_id in each > unit. This is easily fixed by the following patch that makes profiled_id > to by crc32 of the symbol name in this case. > > Bootstrapp

Re: Fix indirect call profiling for COMDAT symbols

2014-04-11 Thread Martin Liška
On 04/11/2014 08:00 AM, Jan Hubicka wrote: Hi, while looking into firefox profiles, I noticed that we miss devirtualizations to comdat symbols, because we manage to get different profile_id in each unit. This is easily fixed by the following patch that makes profiled_id to by crc32 of the symbol

Fix indirect call profiling for COMDAT symbols

2014-04-10 Thread Jan Hubicka
Hi, while looking into firefox profiles, I noticed that we miss devirtualizations to comdat symbols, because we manage to get different profile_id in each unit. This is easily fixed by the following patch that makes profiled_id to by crc32 of the symbol name in this case. Bootstrapped/regtested x