[pushed] Fix profiledbootstrap poly_int fallout [PR111642]

2023-10-02 Thread Richard Sandiford
rtl-tests.cc and simplify-rtx.cc used partial specialisation to try to restrict the NUM_POLY_INT_COEFFS>1 tests without resorting to preprocessor tests. That now triggers an error in some configurations, since the NUM_POLY_INT_COEFFS>1 tests used the global poly_int64, whose definition does not

Fix profiledbootstrap

2023-08-03 Thread Jan Hubicka via Gcc-patches
Hi, Profiledbootstrap fails with ICE in update_loop_exit_probability_scale_dom_bbs called from loop unroling. The reason is that under relatively rare situations, we may run into case where loop has multiple exits and all are considered as likely but then we scale down the profile and one of the

Re: [PATCH] Fix profiledbootstrap - store-merging aliasing issue (PR bootstrap/82916)

2017-11-10 Thread Richard Biener
On Fri, 10 Nov 2017, Jakub Jelinek wrote: > On Fri, Nov 10, 2017 at 08:52:16AM +0100, Richard Biener wrote: > > > @@ -958,8 +959,10 @@ pass_store_merging::terminate_all_aliasi > > >unsigned int i; > > >FOR_EACH_VEC_ELT (cur->m_store_info, i, info) > > > { > > > - if

Re: [PATCH] Fix profiledbootstrap - store-merging aliasing issue (PR bootstrap/82916)

2017-11-10 Thread Jakub Jelinek
On Fri, Nov 10, 2017 at 08:52:16AM +0100, Richard Biener wrote: > > @@ -958,8 +959,10 @@ pass_store_merging::terminate_all_aliasi > >unsigned int i; > >FOR_EACH_VEC_ELT (cur->m_store_info, i, info) > > { > > - if (ref_maybe_used_by_stmt_p (stmt, gimple_assign_lhs

Re: [PATCH] Fix profiledbootstrap - store-merging aliasing issue (PR bootstrap/82916)

2017-11-09 Thread Richard Biener
On Thu, 9 Nov 2017, Jakub Jelinek wrote: > Hi! > > We want to terminate a chain if a chain with different base (or insn > outside of any chain) has a store that the current stmt might use, or > overwrite. The functions it used didn't cover the store after store > case which in the middle-end

[PATCH] Fix profiledbootstrap - store-merging aliasing issue (PR bootstrap/82916)

2017-11-09 Thread Jakub Jelinek
Hi! We want to terminate a chain if a chain with different base (or insn outside of any chain) has a store that the current stmt might use, or overwrite. The functions it used didn't cover the store after store case which in the middle-end aliasing model needs to avoid tbaa, because the latter

[PATCH][OBVIOUS] Fix profiledbootstrap.

2017-10-27 Thread Martin Liška
lt;mli...@suse.cz> Date: Fri, 27 Oct 2017 12:21:02 +0200 Subject: [PATCH] Fix profiledbootstrap. ChangeLog: 2017-10-27 Martin Liska <mli...@suse.cz> * Makefile.tpl: Use proper name of folder as it was renamed during transition to 4 stages. * Makefile.in: Regenerate. --- M

Fix profiledbootstrap

2017-07-20 Thread Jan Hubicka
Hi, this patch fixes ICE during profiledbootstrap about hot BB being dominated by cold. This is verified by RTL verify_flow_info and was added by Theresa along with patches to undo mistakes in in sane profile. The implementation is odd because this is not about dominance but reachability. It is

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-04-04 Thread Eric Botcazou
> eric@polaris:~/build/gcc/native/gcc> rm ada/sem_util.o > eric@polaris:~/build/gcc/native/gcc> make ADAFLAGS="-gnatpgn" > /home/eric/build/gcc/native/./prev-gcc/xgcc - > B/home/eric/build/gcc/native/./prev-gcc/ > -B/home/eric/install/gcc/x86_64-suse- linux/bin/ >

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-04-04 Thread Eric Botcazou
> We have local modifications in the Ada front-end so I cannot reproduce it > with the pristine tree either. :-( I apparently screwed up yesterday, this can be reproduced as such in the directory of a boostrapped compiler: eric@polaris:~/build/gcc/native/gcc> rm ada/sem_util.o

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-04-03 Thread Eric Botcazou
> The following C testcase shows how profiledbootstrap fails with checking > compiler. We have a (nested) FUNCTION_DECL inside of BLOCK_VARS of an > inline function, when it gets inlined, it is moved into > BLOCK_NONLOCALIZED_VARS. And, decls_for_scope calls process_scope_var > with NULL decl

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-03-24 Thread Jakub Jelinek
On Fri, Mar 24, 2017 at 09:07:54AM -0400, Jason Merrill wrote: > >> And when it's cloned. > >> > >> But does it make sense for gen_decl_die to call > >> dwarf2out_abstract_function when decl is null? That seems wrong. > > > > Before r144529 we had just: > > if (DECL_ORIGIN (decl) != decl) > >

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-03-24 Thread Jason Merrill
On Fri, Mar 24, 2017 at 3:46 AM, Jakub Jelinek wrote: > On Thu, Mar 23, 2017 at 05:24:31PM -0400, Jason Merrill wrote: >> On Thu, Mar 23, 2017 at 4:44 PM, Jakub Jelinek wrote: >> > The following C testcase shows how profiledbootstrap fails with checking >> >

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-03-24 Thread Jakub Jelinek
On Fri, Mar 24, 2017 at 12:45:28PM +0100, Richard Biener wrote: > On Fri, Mar 24, 2017 at 9:43 AM, Jakub Jelinek wrote: > > On Fri, Mar 24, 2017 at 09:29:00AM +0100, Richard Biener wrote: > >> Yeah, the thing BLOCK_NONLOCALIZED_VARS wants to do is optimize generated > >> dwarf

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-03-24 Thread Richard Biener
On Fri, Mar 24, 2017 at 9:43 AM, Jakub Jelinek wrote: > On Fri, Mar 24, 2017 at 09:29:00AM +0100, Richard Biener wrote: >> Yeah, the thing BLOCK_NONLOCALIZED_VARS wants to do is optimize generated >> dwarf by adding a DW_AT_abstract_origin (just to refer to the >> subprogram

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-03-24 Thread Jakub Jelinek
On Fri, Mar 24, 2017 at 09:29:00AM +0100, Richard Biener wrote: > Yeah, the thing BLOCK_NONLOCALIZED_VARS wants to do is optimize generated > dwarf by adding a DW_AT_abstract_origin (just to refer to the > subprogram DIE) but Well, for FUNCTION_DECLs in BLOCK_VARS/BLOCK_NONLOCALIZED_VARS we

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-03-24 Thread Richard Biener
On Fri, Mar 24, 2017 at 8:46 AM, Jakub Jelinek wrote: > On Thu, Mar 23, 2017 at 05:24:31PM -0400, Jason Merrill wrote: >> On Thu, Mar 23, 2017 at 4:44 PM, Jakub Jelinek wrote: >> > The following C testcase shows how profiledbootstrap fails with checking >> >

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-03-24 Thread Jakub Jelinek
On Thu, Mar 23, 2017 at 05:24:31PM -0400, Jason Merrill wrote: > On Thu, Mar 23, 2017 at 4:44 PM, Jakub Jelinek wrote: > > The following C testcase shows how profiledbootstrap fails with checking > > compiler. We have a (nested) FUNCTION_DECL inside of BLOCK_VARS of an > >

Re: [PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-03-23 Thread Jason Merrill
On Thu, Mar 23, 2017 at 4:44 PM, Jakub Jelinek wrote: > The following C testcase shows how profiledbootstrap fails with checking > compiler. We have a (nested) FUNCTION_DECL inside of BLOCK_VARS of an > inline function, when it gets inlined, it is moved into >

[PATCH] Fix profiledbootstrap ada checking failure (PR debug/79255)

2017-03-23 Thread Jakub Jelinek
Hi! The following C testcase shows how profiledbootstrap fails with checking compiler. We have a (nested) FUNCTION_DECL inside of BLOCK_VARS of an inline function, when it gets inlined, it is moved into BLOCK_NONLOCALIZED_VARS. And, decls_for_scope calls process_scope_var with NULL decl and

Re: [PATCH] fix profiledbootstrap with -Werror=format-length (77753)

2016-09-28 Thread Martin Sebor
On 09/27/2016 10:38 PM, Jeff Law wrote: On 09/27/2016 01:30 PM, Martin Sebor wrote: The attached one line patch increases a local buffer size to avoid an apparently justified (though in reality likely a false positive) -Wformat-length warning in varasm.c. The warning has been reported to break

Re: [PATCH] fix profiledbootstrap with -Werror=format-length (77753)

2016-09-27 Thread Jeff Law
On 09/27/2016 01:30 PM, Martin Sebor wrote: The attached one line patch increases a local buffer size to avoid an apparently justified (though in reality likely a false positive) -Wformat-length warning in varasm.c. The warning has been reported to break profiledbootstrap on powerp64le (though

[PATCH] fix profiledbootstrap with -Werror=format-length (77753)

2016-09-27 Thread Martin Sebor
The attached one line patch increases a local buffer size to avoid an apparently justified (though in reality likely a false positive) -Wformat-length warning in varasm.c. The warning has been reported to break profiledbootstrap on powerp64le (though not ordinary bootstrap). An arguably better

Re: Fix profiledbootstrap with release checking

2015-01-16 Thread Markus Trippelsdorf
On 2015.01.16 at 00:15 +0100, Jan Hubicka wrote: Hi, can_remove_node_now_p assumes that the node in question has no direct calls, this however is not checked in inline_call that leads to alias to be removed from comdat group while it should not. Bootstrapped/regtested x86_64-linux,

Re: Fix profiledbootstrap with release checking

2015-01-16 Thread Richard Biener
On Fri, Jan 16, 2015 at 9:34 AM, Markus Trippelsdorf mar...@trippelsdorf.de wrote: On 2015.01.16 at 00:15 +0100, Jan Hubicka wrote: Hi, can_remove_node_now_p assumes that the node in question has no direct calls, this however is not checked in inline_call that leads to alias to be removed

Re: Fix profiledbootstrap with release checking

2015-01-16 Thread Markus Trippelsdorf
On 2015.01.16 at 12:03 +0100, Richard Biener wrote: On Fri, Jan 16, 2015 at 9:34 AM, Markus Trippelsdorf mar...@trippelsdorf.de wrote: On 2015.01.16 at 00:15 +0100, Jan Hubicka wrote: Hi, can_remove_node_now_p assumes that the node in question has no direct calls, this however is not

Fix profiledbootstrap with release checking

2015-01-15 Thread Jan Hubicka
Hi, can_remove_node_now_p assumes that the node in question has no direct calls, this however is not checked in inline_call that leads to alias to be removed from comdat group while it should not. Bootstrapped/regtested x86_64-linux, comitted. Honza PR ipa/64612 *

[google gcc-4_8] fix profiledbootstrap

2014-02-04 Thread Rong Xu
Hi, The attached patch fixes the duplicated definition error in gcov-tool.c in profiledbootstrap. Google branch only and tested with profiledbootstrap. Ok for checking in? -Rong Index: gcov-tool.c === --- gcov-tool.c (revision

Re: [google gcc-4_8] fix profiledbootstrap

2014-02-04 Thread Xinliang David Li
ok. David On Tue, Feb 4, 2014 at 11:28 AM, Rong Xu x...@google.com wrote: Hi, The attached patch fixes the duplicated definition error in gcov-tool.c in profiledbootstrap. Google branch only and tested with profiledbootstrap. Ok for checking in? -Rong

Re: [PATCH, bootstrap]: Initialize deref_align in ipa_modify_call_arguments to fix profiledbootstrap

2013-09-09 Thread Richard Biener
On Sat, Sep 7, 2013 at 10:15 AM, Uros Bizjak ubiz...@gmail.com wrote: Hello! It looks that it is too hard for the compiler to track deref_align initialization through dependent deref_base boolean. The patch bellow fixes may be used uninitialized warning that breaks profiledbootstrap.

[PATCH, bootstrap]: Initialize deref_align in ipa_modify_call_arguments to fix profiledbootstrap

2013-09-07 Thread Uros Bizjak
Hello! It looks that it is too hard for the compiler to track deref_align initialization through dependent deref_base boolean. The patch bellow fixes may be used uninitialized warning that breaks profiledbootstrap. 2013-09-07 Uros Bizjak ubiz...@gmail.com * ipa-prop.c

[Ping] [Google] Fix profiledbootstrap failure

2013-08-01 Thread Dinar Temirbulatov
Ping? Hi, Here is the patch, Tested by profiledbootstrap. Ok for google gcc-4.8? thanks, Dinar. profiledbootstrap-fix1.patch Description: Binary data

Re: [Ping] [Google] Fix profiledbootstrap failure

2013-08-01 Thread Xinliang David Li
Sorry for the delay. The patch is ok and I have committed it to the google branch. thanks, David On Thu, Aug 1, 2013 at 4:51 PM, Dinar Temirbulatov di...@kugelworks.com wrote: Ping? Hi, Here is the patch, Tested by profiledbootstrap. Ok for google gcc-4.8? thanks, Dinar.

Re: [Google] Fix profiledbootstrap failure

2013-07-31 Thread Dinar Temirbulatov
Hi, Here is the patch, Tested by profiledbootstrap. Ok for google gcc-4.8? thanks, Dinar. On Wed, Jul 31, 2013 at 12:01 AM, Rong Xu x...@google.com wrote: Will do. The patch was in gcc-4_7 by Dehao. r194713 | dehao | 2012-12-24 16:49:06 -0800 (Mon, 24 Dec 2012) | 5 lines

[Google] Fix profiledbootstrap failure

2013-07-30 Thread Dinar Temirbulatov
Hello This change allows to complete profiledbootstrap on the google gcc-4.8 branch, tested with make bootstrap with no new regressions. OK for google 4.8? thanks, Dinar. profiledbootstrap-fix.patch Description: Binary data

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Teresa Johnson
cc'ing Rong and David since this came from LIPO support. The patch as-is removes the one use of PARAM_GCOV_DEBUG (which is on by default) without removing the parameter itself. What is the failure mode you see from this code? Thanks, Teresa On Tue, Jul 30, 2013 at 11:50 AM, Dinar Temirbulatov

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Xinliang David Li
I need to understand why this affects profile bootstrap -- is this due to file name conflict? The fix is wrong -- please do not remove the parameter. If it is a problem, a better fix is to change the default parameter value to 0. David On Tue, Jul 30, 2013 at 11:56 AM, Teresa Johnson

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Rong Xu
We have seen the issue before. It does fail the profile boostrap as it reads a wrong gcda file. I thought it had been fixed. (The fix was as David mentioned, setting the default value of the parameter to 0). -Rong On Tue, Jul 30, 2013 at 12:02 PM, Xinliang David Li davi...@google.com wrote: I

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Dinar Temirbulatov
I need to understand why this affects profile bootstrap -- is this due to file name conflict? Yes, It is simple. During the profiledbootstrap on x86_64 platform for libiberty the compiler picks an incorrect profile from the current directory(non-pic version), while compiling pic version, and

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Xinliang David Li
Ok. Rong, can you help commit the parameter default setting patch? thanks, David On Tue, Jul 30, 2013 at 12:48 PM, Rong Xu x...@google.com wrote: We have seen the issue before. It does fail the profile boostrap as it reads a wrong gcda file. I thought it had been fixed. (The fix was as David

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Rong Xu
Will do. The patch was in gcc-4_7 by Dehao. r194713 | dehao | 2012-12-24 16:49:06 -0800 (Mon, 24 Dec 2012) | 5 lines Fix the profiled bootstrap: 1. Set the default value of gcov-debug to be 0. 2. Merge profile summaries from different instrumented binaries. On Tue, Jul 30, 2013 at 12:58 PM,

Re: [PATCH] Fix profiledbootstrap with -fexceptions (PR bootstrap/51648)

2012-01-05 Thread Richard Guenther
On Thu, Jan 5, 2012 at 1:13 AM, Jakub Jelinek ja...@redhat.com wrote: Hi! profiledbootstrap with --disable-poststage-build-with-cxx and -fexceptions currently fails on x86_64-linux.  The problem is that no EDGE_FAKE edge is added from noreturn fatal_error call to the exit block, eventhough

[PATCH] Fix profiledbootstrap with -fexceptions (PR bootstrap/51648)

2012-01-04 Thread Jakub Jelinek
Hi! profiledbootstrap with --disable-poststage-build-with-cxx and -fexceptions currently fails on x86_64-linux. The problem is that no EDGE_FAKE edge is added from noreturn fatal_error call to the exit block, eventhough fatal_error calls exit. The problem is that we have several places which add

[PATCH] Fix profiledbootstrap failures

2011-12-21 Thread Jakub Jelinek
Hi! My profiledbootstrap --enable-checking=release (and lots of other configury options) failed this morning, I got warnings (promoted to errors due to -Werror*) because our uninitialized warning code couldn't figure these out. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,

Re: [PATCH] Fix profiledbootstrap failures

2011-12-21 Thread Richard Guenther
On Wed, Dec 21, 2011 at 3:21 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! My profiledbootstrap --enable-checking=release (and lots of other configury options) failed this morning, I got warnings (promoted to errors due to -Werror*) because our uninitialized warning code couldn't figure these