---------- Forwarded message ---------- From: Caroline Tice <cmt...@google.com> Date: Wed, Aug 26, 2015 at 12:50 PM Subject: Re: [libvtv] Fix formatting errors To: Jeff Law <l...@redhat.com> Cc: Rainer Orth <r...@cebitec.uni-bielefeld.de>, GCC Patches <gcc-patches@gcc.gnu.org>
As far as I know vtv is working just fine...is there something I don't know about? -- Caroline cmt...@google.com On Wed, Aug 26, 2015 at 12:47 PM, Jeff Law <l...@redhat.com> wrote: > > On 08/26/2015 07:30 AM, Rainer Orth wrote: >> >> While looking at libvtv for the Solaris port, I noticed all sorts of GNU >> Coding Standard violations: >> >> * ChangeLog entries attributed to the committer instead of the author >> and with misformatted PR references, entries only giving a vague >> rational instead of what changed >> >> * overlong lines >> >> * tons of whitespace errors (though I may be wrong in some cases: C++ >> code might have other rules) >> >> * code formatting that seems to have been done to be visually pleasing, >> completely different from what Emacs does >> >> * commented code fragments (#if 0 equivalent) >> >> * configure.tgt target list in no recognizable order >> >> * the Cygwin/MingW port is done in the worst possible way: tons of >> target-specific ifdefs instead of feature-specific conditionals or an >> interface that can wrap both Cygwin and Linux variants of the code >> >> The following patch (as yet not even compiled) fixes some of the most >> glaring errors. The Solaris port will fix a few of the latter ones. >> >> Do you think this is the right direction or did I get something wrong? >> >> Thanks. >> Rainer >> >> >> 2015-08-26 Rainer Orth <r...@cebitec.uni-bielefeld.de> >> >> Fix formatting errors. > > I'm more interested in the current state of vtv as I keep getting dragged > into discussions about what we can/should be doing in the compiler world to > close more security stuff. > > Vtables are an obvious candidate given we've got vtv. > > Jeff
