Hi Ian,
> On Mon, Feb 18, 2019 at 2:48 AM Rainer Orth
> wrote:
>>
>> > The code was already calling syscall, it was just doing it in a way
>> > that the types didn't necessarily match the C declaration. This is
>> > the implementation of Go's syscall.Syscall function, so there isn't
>> >
On Mon, Feb 18, 2019 at 2:48 AM Rainer Orth
wrote:
>
> > The code was already calling syscall, it was just doing it in a way
> > that the types didn't necessarily match the C declaration. This is
> > the implementation of Go's syscall.Syscall function, so there isn't
> > really anything else we
Hi Ian,
> On Fri, Feb 15, 2019 at 4:03 AM Rainer Orth
> wrote:
>>
>> Andreas Schwab writes:
>>
>> > This breaks non-split-stack builds.
>> >
>> > ../../../libgo/runtime/stack.c: In function 'doscanstack1':
>> > ../../../libgo/runtime/stack.c:113:18: error: passing argument 1 of
>> >
On Fri, Feb 15, 2019 at 4:03 AM Rainer Orth
wrote:
>
> Andreas Schwab writes:
>
> > This breaks non-split-stack builds.
> >
> > ../../../libgo/runtime/stack.c: In function 'doscanstack1':
> > ../../../libgo/runtime/stack.c:113:18: error: passing argument 1 of
> > 'scanstackblock' makes integer
On Fri, Feb 15, 2019 at 12:15 AM Andreas Schwab wrote:
>
> This breaks non-split-stack builds.
>
> ../../../libgo/runtime/stack.c: In function 'doscanstack1':
> ../../../libgo/runtime/stack.c:113:18: error: passing argument 1 of
> 'scanstackblock' makes integer from pointer without a cast
>
Andreas Schwab writes:
> This breaks non-split-stack builds.
>
> ../../../libgo/runtime/stack.c: In function 'doscanstack1':
> ../../../libgo/runtime/stack.c:113:18: error: passing argument 1 of
> 'scanstackblock' makes integer from pointer without a cast
> [-Werror=int-conversion]
> 113 |
This breaks non-split-stack builds.
../../../libgo/runtime/stack.c: In function 'doscanstack1':
../../../libgo/runtime/stack.c:113:18: error: passing argument 1 of
'scanstackblock' makes integer from pointer without a cast
[-Werror=int-conversion]
113 | scanstackblock(bottom, (uintptr)(top
This patch to the Go frontend and libgo by Nikhil Benesch harmonizes
types referenced by both C and Go. Compiling with LTO revealed a
number of cases in the runtime and standard library where C and Go
disagreed about the type of an object or function (or where Go and
code generated by the
