Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Ian Lance Taylor
On Fri, Oct 26, 2018 at 9:13 AM, Rainer Orth wrote: > Hi Than, > >> OK, thanks again. Another fix sent: >> >> https://go-review.googlesource.com/c/gofrontend/+/145021 > > great, thanks again. While the two previous patches were enough to get > decent Solaris 11 results, on Solaris 10 all libgo

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Bernhard Reutner-Fischer
On 26 October 2018 18:13:32 CEST, Rainer Orth wrote: >Hi Than, > >> OK, thanks again. Another fix sent: >> >> https://go-review.googlesource.com/c/gofrontend/+/145021 > >great, thanks again. While the two previous patches were enough to get >decent Solaris 11 results, on Solaris 10 all libgo

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Ian Lance Taylor
On Fri, Oct 26, 2018 at 7:44 AM, Than McIntosh wrote: > OK, thanks again. Another fix sent: > > https://go-review.googlesource.com/c/gofrontend/+/145021 Thanks. Sorry for missing that in code review. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Ian Lance Taylor
On Fri, Oct 26, 2018 at 5:04 AM, Than McIntosh wrote: > > Thanks for reporting this. > > Sent https://go-review.googlesource.com/c/gofrontend/+/145017 with a > tentative fix. Thanks, committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Rainer Orth
Hi Than, > OK, thanks again. Another fix sent: > > https://go-review.googlesource.com/c/gofrontend/+/145021 great, thanks again. While the two previous patches were enough to get decent Solaris 11 results, on Solaris 10 all libgo tests still FAIL like this: _testmain.go:9:25: error: reference

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Than McIntosh via gcc-patches
OK, thanks again. Another fix sent: https://go-review.googlesource.com/c/gofrontend/+/145021 Cheers, Than On Fri, Oct 26, 2018 at 10:20 AM Rainer Orth wrote: > > Hi Than, > > > Thanks for reporting this. > > > > Sent https://go-review.googlesource.com/c/gofrontend/+/145017 with a > >

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Rainer Orth
Hi Than, > Thanks for reporting this. > > Sent https://go-review.googlesource.com/c/gofrontend/+/145017 with a > tentative fix. fine, thanks. While actually running the libgo testsuite, another issue came up: all tests FAIL like this: /vol/gcc/src/hg/trunk/local/libgo/testsuite/gotest[516]:

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Than McIntosh via gcc-patches
Thanks for reporting this. Sent https://go-review.googlesource.com/c/gofrontend/+/145017 with a tentative fix. Than On Fri, Oct 26, 2018 at 7:55 AM Rainer Orth wrote: > > Hi Ian, > > > This patch by Than McIntosh improves the mangling of package paths in > > the Go frontend. > > > > The

Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Rainer Orth
Hi Ian, > This patch by Than McIntosh improves the mangling of package paths in > the Go frontend. > > The current implementation of Gogo::pkgpath_for_symbol was written in > a way that allowed two distinct package paths to map to the same > symbol, which could cause collisions at link- time or

Go patch committed: Improve name mangling for package paths

2018-10-25 Thread Ian Lance Taylor
This patch by Than McIntosh improves the mangling of package paths in the Go frontend. The current implementation of Gogo::pkgpath_for_symbol was written in a way that allowed two distinct package paths to map to the same symbol, which could cause collisions at link- time or compile-time. This