Re: Go patch committed: Update libgo to Go release r60

2011-09-28 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: Rainer Orth r...@cebitec.uni-bielefeld.de writes: Solaris 8 and 9 suffer from the same problem. The following patch allowed the bootstrap to complete. An IRIX bootstrap is currently running, but will take some time to complete. Rainer

Re: Go patch committed: Update libgo to Go release r60

2011-09-28 Thread Ian Lance Taylor
Rainer Orth r...@cebitec.uni-bielefeld.de writes: Thanks, I'd missed that. It turned out that IRIX 6 needs one more change to return to bootstrap land: sys/termios.h only defines TIOCNOTTY if !_XOPEN_SOURCE, which we need for other stuff (cf. configure.ac). I've cheated and use sys/ttold.h

Re: Go patch committed: Update libgo to Go release r60

2011-09-27 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: * IRIX will be worse: while it has TIOCNOTTY, it completely lacks TIOCSCTTY. Suggestions? For a missing TIOCSCTTY I think the simplest solution will be to set it in syscall_irix.go to some innocuous value if there is one. E.g., TIOCNXCL if Irix

Re: Go patch committed: Update libgo to Go release r60

2011-09-27 Thread Ian Lance Taylor
Rainer Orth r...@cebitec.uni-bielefeld.de writes: Solaris 8 and 9 suffer from the same problem. The following patch allowed the bootstrap to complete. An IRIX bootstrap is currently running, but will take some time to complete. Rainer 2011-09-23 Rainer Orth

Re: Go patch committed: Update libgo to Go release r60

2011-09-26 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: Rainer Orth r...@cebitec.uni-bielefeld.de writes: Unfortunately, the /vol/gcc/src/hg/trunk/local/libgo/syscalls/exec.go:11:14: error: imported and not used: unsafe error remains. I've no idea what triggers it. Bother. Neither do I. I just

Re: Go patch committed: Update libgo to Go release r60

2011-09-26 Thread Ian Lance Taylor
Rainer Orth r...@cebitec.uni-bielefeld.de writes: the problem turned out to be obvious once you ignore most of the error message ;-( The spurious import is in sysinfo.go, which unconditionally imports the package, but only uses in some cases. Ah. This patch fixes the location of the error

Re: Go patch committed: Update libgo to Go release r60

2011-09-26 Thread Ian Lance Taylor
Rainer Orth r...@cebitec.uni-bielefeld.de writes: the problem turned out to be obvious once you ignore most of the error message ;-( The spurious import is in sysinfo.go, which unconditionally imports the package, but only uses in some cases. And this patch should fix the Solaris problem.

Re: Go patch committed: Update libgo to Go release r60

2011-09-26 Thread Ian Lance Taylor
Rainer Orth r...@cebitec.uni-bielefeld.de writes: Apart from the (already fixed) go.* dejagnu errors, I noticed another problem: the libgo net test now fails on Solaris, but only with Sun ld: Undefined first referenced symbol in file

Re: Go patch committed: Update libgo to Go release r60

2011-09-23 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: * The Solaris 11/x86 libgo bootstrap dies like this: /vol/gcc/src/hg/trunk/local/libgo/syscalls/exec.go:11:14: error: imported and not used: unsafe That is odd since the file clearly does use unsafe. Perhaps it is somehow a consequence of the

Re: Go patch committed: Update libgo to Go release r60

2011-09-23 Thread Ian Lance Taylor
Rainer Orth r...@cebitec.uni-bielefeld.de writes: Is tIOC defined in gen-sysinfo.go? In sys/termios.h? Does some other Only as // unknowndefine tIOC ('t'8) Ah. I committed this patch which may fix this problem. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. You'll have

Re: Go patch committed: Update libgo to Go release r60

2011-09-23 Thread Rainer Orth
Ian, Is tIOC defined in gen-sysinfo.go? In sys/termios.h? Does some other Only as // unknowndefine tIOC ('t'8) Ah. I committed this patch which may fix this problem. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. You'll have to remove TARGET/libgo/s-sysinfo to force

Re: Go patch committed: Update libgo to Go release r60

2011-09-23 Thread Ian Lance Taylor
Rainer Orth r...@cebitec.uni-bielefeld.de writes: Unfortunately, the /vol/gcc/src/hg/trunk/local/libgo/syscalls/exec.go:11:14: error: imported and not used: unsafe error remains. I've no idea what triggers it. Bother. Neither do I. I just looked through the code and it all looks fine.

Re: Go patch committed: Update libgo to Go release r60

2011-09-22 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: History shows that Go library updates sometimes break the Go build on non-GNU/Linux targets. I tried to be careful this time, but please let me know about any new problems. As expected, this did break Solaris bootstrap and will also break IRIX

Re: Go patch committed: Update libgo to Go release r60

2011-09-22 Thread Ian Lance Taylor
Rainer Orth r...@cebitec.uni-bielefeld.de writes: Ian Lance Taylor i...@google.com writes: History shows that Go library updates sometimes break the Go build on non-GNU/Linux targets. I tried to be careful this time, but please let me know about any new problems. As expected, this did