Re: Minor type merging optimization

2011-05-09 Thread Jan Hubicka
On Fri, May 6, 2011 at 10:24 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, while looking at type merging code I noticed that type pairs can be managed to be ordered by their UIDs.  This save some of hashing overhead in one of most intensively querried hashes. Also

Re: Minor type merging optimization

2011-05-09 Thread Richard Guenther
On Mon, 9 May 2011, Jan Hubicka wrote: On Fri, May 6, 2011 at 10:24 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, while looking at type merging code I noticed that type pairs can be managed to be ordered by their UIDs.  This save some of hashing overhead in one of most intensively

Re: Minor type merging optimization

2011-05-09 Thread Richard Guenther
On Mon, 9 May 2011, Jan Hubicka wrote: On Fri, May 6, 2011 at 10:24 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, while looking at type merging code I noticed that type pairs can be managed to be ordered by their UIDs.  This save some of hashing overhead in one of most intensively

Re: Minor type merging optimization

2011-05-09 Thread Jan Hubicka
I hacked quick unionfind two days ago, but the stopper is that the cache is temporarily caching equilvaences in SCC regions. You mentioned it is no longer neccesary, so perhaps if you send me patch to remove this, I can give a try to this idea. I think we already do exactly this.

Re: Minor type merging optimization

2011-05-09 Thread Richard Guenther
On Mon, 9 May 2011, Jan Hubicka wrote: I hacked quick unionfind two days ago, but the stopper is that the cache is temporarily caching equilvaences in SCC regions. You mentioned it is no longer neccesary, so perhaps if you send me patch to remove this, I can give a try to

Re: Minor type merging optimization

2011-05-09 Thread Jan Hubicka
I haven't yet tested this (apart from with running the LTO testsuite), but I'm going to give the following bootstrap SPEC2k6 LTO build tests. Richard. 2011-05-09 Richard Guenther rguent...@suse.de * gimple.c (gtc_visited, gtc_ob, struct type_pair_d, type_pair_t,

Re: Minor type merging optimization

2011-05-07 Thread Richard Guenther
On Fri, May 6, 2011 at 10:24 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, while looking at type merging code I noticed that type pairs can be managed to be ordered by their UIDs.  This save some of hashing overhead in one of most intensively querried hashes. Also gimple_lookup_type_leader is

Minor type merging optimization

2011-05-06 Thread Jan Hubicka
Hi, while looking at type merging code I noticed that type pairs can be managed to be ordered by their UIDs. This save some of hashing overhead in one of most intensively querried hashes. Also gimple_lookup_type_leader is hot function that is better to be inlined. I also wonder, why unionfind