Re: New options to disable/enable any pass for any functions (issue4550056)

2011-06-01 Thread Jan Hubicka
Please discard the previous one. This is the right one: David Index: tree-pretty-print.c === --- tree-pretty-print.c (revision 174424) +++ tree-pretty-print.c (working copy) @@ -3013,3 +3013,36 @@

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-06-01 Thread Richard Guenther
On Wed, Jun 1, 2011 at 2:03 AM, Xinliang David Li davi...@google.com wrote: Please discard the previous one. This is the right one: See also Honzas comments (on the wrong patch presumably ;)). + if (node) +fprintf (dump_file, \n;; Function %s (%s, funcdef_no=%d, decl_uid = %d,

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-06-01 Thread Jan Hubicka
On Wed, Jun 1, 2011 at 2:03 AM, Xinliang David Li davi...@google.com wrote: Please discard the previous one. This is the right one: See also Honzas comments (on the wrong patch presumably ;)). + if (node) +fprintf (dump_file, \n;; Function %s (%s, funcdef_no=%d, decl_uid = %d,

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-31 Thread Richard Guenther
On Mon, May 30, 2011 at 10:16 PM, Xinliang David Li davi...@google.com wrote: The attached are two simple follow up patches 1) the first patch does some refactorization on function header dumping (with more information printed) 2) the second patch cleans up some pass names. Part of the

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-31 Thread Richard Guenther
On Mon, May 30, 2011 at 11:44 PM, Xinliang David Li davi...@google.com wrote: This is the complete patch for pass name fixes (with test case changes). This is ok if Honza thinks the profile pass names make more sense this way. Thanks, Richard. David On Mon, May 30, 2011 at 1:16 PM,

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-31 Thread Xinliang David Li
On Tue, May 31, 2011 at 2:05 AM, Richard Guenther richard.guent...@gmail.com wrote: On Mon, May 30, 2011 at 10:16 PM, Xinliang David Li davi...@google.com wrote: The attached are two simple follow up patches 1) the first patch does some refactorization on function header dumping (with more

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-31 Thread Xinliang David Li
The new patch is attached. The test (c,c++,fortran, java, ada) is on going. Thanks, David On Tue, May 31, 2011 at 9:06 AM, Xinliang David Li davi...@google.com wrote: On Tue, May 31, 2011 at 2:05 AM, Richard Guenther richard.guent...@gmail.com wrote: On Mon, May 30, 2011 at 10:16 PM,

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-31 Thread Xinliang David Li
Honza, are you ok with the pass name change? David On Tue, May 31, 2011 at 2:07 AM, Richard Guenther richard.guent...@gmail.com wrote: On Mon, May 30, 2011 at 11:44 PM, Xinliang David Li davi...@google.com wrote: This is the complete patch for pass name fixes (with test case changes). This

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-31 Thread Xinliang David Li
Please discard the previous one. This is the right one: David On Tue, May 31, 2011 at 5:01 PM, Xinliang David Li davi...@google.com wrote: The new patch is attached. The test (c,c++,fortran, java, ada) is on going. Thanks, David On Tue, May 31, 2011 at 9:06 AM, Xinliang David Li

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-30 Thread Xinliang David Li
The attached are two simple follow up patches 1) the first patch does some refactorization on function header dumping (with more information printed) 2) the second patch cleans up some pass names. Part of the cleanup results from a previous discussion with Honza -- a) rename 'tree_profile_ipa'

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-30 Thread Xinliang David Li
This is the complete patch for pass name fixes (with test case changes). David On Mon, May 30, 2011 at 1:16 PM, Xinliang David Li davi...@google.com wrote: The attached are two simple follow up patches 1) the first patch does some refactorization on function header dumping (with more

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-27 Thread Richard Guenther
On Fri, May 27, 2011 at 12:02 AM, Xinliang David Li davi...@google.com wrote: The latest version that only exports 2 functions from passes.c. Ok with ... @@ -637,4 +637,8 @@ extern bool first_pass_instance; /* Declare for plugins. */ extern void do_per_function_toporder (void (*) (void *),

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-26 Thread Richard Guenther
On Wed, May 25, 2011 at 6:53 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Wed, 25 May 2011, Xinliang David Li wrote: Ping. The link to the message: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01303.html I don't consider this an option handling patch.  Patches adding whole new

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-26 Thread Joseph S. Myers
On Thu, 26 May 2011, Richard Guenther wrote: + if (is_enable) +error (unrecognized option -fenable); + else +error (unrecognized option -fdisable); I think that should be fatal_error - Joseph? No, all existing errors for unknown options are ordinary errors rather

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-26 Thread Xinliang David Li
The latest version that only exports 2 functions from passes.c. David On Thu, May 26, 2011 at 2:04 PM, Xinliang David Li davi...@google.com wrote: On Thu, May 26, 2011 at 2:04 AM, Richard Guenther richard.guent...@gmail.com wrote: On Wed, May 25, 2011 at 6:53 PM, Joseph S. Myers

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-25 Thread Xinliang David Li
Ping. The link to the message: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01303.html Thanks, David On Sun, May 22, 2011 at 4:17 PM, Xinliang David Li davi...@google.com wrote: Ping. David On Fri, May 20, 2011 at 9:06 AM, Xinliang David Li davi...@google.com wrote: Ok to check in this

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-25 Thread Joseph S. Myers
On Wed, 25 May 2011, Xinliang David Li wrote: Ping. The link to the message: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01303.html I don't consider this an option handling patch. Patches adding whole new features involving new options should be reviewed by maintainers for the part of

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-22 Thread Xinliang David Li
Ping. David On Fri, May 20, 2011 at 9:06 AM, Xinliang David Li davi...@google.com wrote: Ok to check in this one? Thanks, David On Wed, May 18, 2011 at 12:30 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Wed, 18 May 2011, David Li wrote: +      error (Unrecognized option %s,

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-20 Thread Xinliang David Li
Ok to check in this one? Thanks, David On Wed, May 18, 2011 at 12:30 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Wed, 18 May 2011, David Li wrote: +      error (Unrecognized option %s, is_enable ? -fenable : -fdisable); +      error (Unknown pass %s specified in %s, +          

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-19 Thread Andi Kleen
davi...@google.com (David Li) writes: -fdisable-tree-ccp1--- disable ccp1 for all functions -fenable-tree-cunroll=1 --- enable complete unroll for the function whose cgraphnode uid is 1 -fdisable-rtl-gcse2=1:100,300,400:1000 -- disable gcse2 for

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-19 Thread Xinliang David Li
On Thu, May 19, 2011 at 11:04 AM, Andi Kleen a...@firstfloor.org wrote: davi...@google.com (David Li) writes: -fdisable-tree-ccp1    --- disable ccp1 for all functions -fenable-tree-cunroll=1   --- enable complete unroll for the function                            whose cgraphnode uid is 1

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-19 Thread Andi Kleen
On Thu, May 19, 2011 at 11:10:24AM -0700, Xinliang David Li wrote: On Thu, May 19, 2011 at 11:04 AM, Andi Kleen a...@firstfloor.org wrote: davi...@google.com (David Li) writes: -fdisable-tree-ccp1    --- disable ccp1 for all functions -fenable-tree-cunroll=1   --- enable complete unroll

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-19 Thread Xinliang David Li
On Thu, May 19, 2011 at 11:17 AM, Andi Kleen a...@firstfloor.org wrote: On Thu, May 19, 2011 at 11:10:24AM -0700, Xinliang David Li wrote: On Thu, May 19, 2011 at 11:04 AM, Andi Kleen a...@firstfloor.org wrote: davi...@google.com (David Li) writes: -fdisable-tree-ccp1    --- disable ccp1

New options to disable/enable any pass for any functions (issue4550056)

2011-05-18 Thread David Li
In gcc, not all passes have user level control to turn it on/off, and there is no way to flip on/off the pass for a subset of functions. I implemented a generic option handling scheme in gcc to allow disabling/enabling any gcc pass for any specified function(s). The new options will be very

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-18 Thread Xinliang David Li
Thanks for the comment. Will fix those. David On Wed, May 18, 2011 at 12:30 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Wed, 18 May 2011, David Li wrote: +      error (Unrecognized option %s, is_enable ? -fenable : -fdisable); +      error (Unknown pass %s specified in %s, +    

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-18 Thread Richard Guenther
On Wed, May 18, 2011 at 8:37 PM, David Li davi...@google.com wrote: In gcc, not all passes have user level control to turn it on/off, and there is no way to flip on/off the pass for a subset of functions. I implemented a generic option handling scheme in gcc to allow disabling/enabling any

Re: New options to disable/enable any pass for any functions (issue4550056)

2011-05-18 Thread Xinliang David Li
Will fix the Changelog, and add documentation. Thanks, David On Wed, May 18, 2011 at 1:26 PM, Richard Guenther richard.guent...@gmail.com wrote: On Wed, May 18, 2011 at 8:37 PM, David Li davi...@google.com wrote: In gcc, not all passes have user level control to turn it on/off, and there