PR92036 "OpenACC 'firstprivate' clause: initial value"

Hi! In r276757 "[PR92036] Add 'libgomp.oacc-c-c++-common/data-firstprivate-1.c'", I committed the attached to document the status quo, and then what I think it instead should be per PR92036 "OpenACC 'firstprivate' clause: initial value".

[committed] [PR90859] Document status quo for "[OMP] Mappings for VLA different depending on 'target { c && { ! lp64 } }'" (was: [committed] Test cases to verify OpenACC 'firstprivate' mappings)

Hi! On Wed, 19 Jun 2019 00:47:27 +0200, I wrote: > I committed to trunk in r272451 a few "Test cases to verify OpenACC > 'firstprivate' mappings" > --- /dev/null > +++ b/gcc/testsuite/c-c++-common/goacc/firstprivate-mappings-1.c > +static void > +vla (int array_l

[committed] Test cases to verify OpenACC 'firstprivate' mappings

Hi! I committed to trunk in r272451 a few "Test cases to verify OpenACC 'firstprivate' mappings", see attached. More to come, later on. Grüße Thomas From 2f195960a11d9eb027e4abcfc5faaca2ff5fe9e3 Mon Sep 17 00:00:00 2001 From: tschwinge Date: Tue, 18 Jun 2019 22:15:03 + Subje

Re: OpenACC Firstprivate

Hi Nathan! Merging back your trunk r230169 into gomp-4_0-branch, for the new libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-2.c test, I'm seeing the compiler diagnose as follows (compile with "-Wall -O2"): source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-2.c: In

Re: OpenACC Firstprivate

On 11/11/15 03:04, Jakub Jelinek wrote: On Tue, Nov 10, 2015 at 09:12:55AM -0500, Nathan Sidwell wrote: + /* Create a local object to hold the instance + value. */ + tree inst = create_tmp_var + (TREE_TYPE (TREE_TYPE

Re: OpenACC Firstprivate

On Tue, Nov 10, 2015 at 09:12:55AM -0500, Nathan Sidwell wrote: > + /* Create a local object to hold the instance > +value. */ > + tree inst = create_tmp_var > + (TREE_TYPE (TREE_TYPE (new_var)), > +

Re: OpenACC Firstprivate

just OpenACC region types. (gimplify_omp_target_update): Likewise. * gcc/omp-low.c (scan_sharing_clauses): Remove Openacc firstprivate sorry. (lower-rec_input_clauses): Don't handle openacc firstprivate references here. (lower_omp_target): Emit initializers for openacc firstprivate vars. g

Re: OpenACC Firstprivate

On Mon, Nov 09, 2015 at 08:59:15AM -0500, Nathan Sidwell wrote: > >This I'm afraid performs often two copies rather than just one (one to copy > >the host value to the present_copyin mapped value, another one in the > >region), > > I don't think that can be avoided. The host doesn't have control

Re: OpenACC Firstprivate

On Sat, Nov 07, 2015 at 08:50:28AM -0500, Nathan Sidwell wrote: > Index: gcc/gimplify.c > === > --- gcc/gimplify.c(revision 229892) > +++ gcc/gimplify.c(working copy) > @@ -108,9 +108,15 @@ enum omp_region_type >/* Data

Re: OpenACC Firstprivate

On 11/09/15 08:46, Jakub Jelinek wrote: On Sat, Nov 07, 2015 at 08:50:28AM -0500, Nathan Sidwell wrote: Index: gcc/gimplify.c === If you want to switch to hexadecimal, you should change all values in the enum to hexadecimal for

Re: OpenACC Firstprivate

On 11/09/15 08:59, Nathan Sidwell wrote: On 11/09/15 08:46, Jakub Jelinek wrote: On Sat, Nov 07, 2015 at 08:50:28AM -0500, Nathan Sidwell wrote: Say int arr[64]; // initialize arr #pragma acc data copyin (arr) { // modify arr on the host # pragma acc parallel firstprivate (arr)

Re: OpenACC Firstprivate

On 11/09/15 09:10, Jakub Jelinek wrote: On Mon, Nov 09, 2015 at 08:59:15AM -0500, Nathan Sidwell wrote: This I'm afraid performs often two copies rather than just one (one to copy the host value to the present_copyin mapped value, another one in the region), I don't think that can be avoided.

OpenACC Firstprivate

ACC region types. (gimplify_omp_target_update): Likewise. * gcc/omp-low.c (scan_sharing_clauses): Remove Openacc firstprivate sorry. (lower-rec_input_clauses): Don't handle openacc firstprivate references here. (lower_omp_target): Emit initializers for openacc firstprivate vars. gcc/testsuite/ * gfortran.dg/goa