Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 7:51 AM, Uros Bizjak wrote: > On Fri, Nov 14, 2014 at 3:38 PM, H.J. Lu wrote: >> On Thu, Nov 13, 2014 at 09:32:07PM -0800, H.J. Lu wrote: >>> For i[34567]86-*-linux* and x86_64-*-linux* targets, config.gcc assumes >>> modern glibc and set default_gnu_indirect_function to y

Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread Uros Bizjak
On Fri, Nov 14, 2014 at 3:38 PM, H.J. Lu wrote: > On Thu, Nov 13, 2014 at 09:32:07PM -0800, H.J. Lu wrote: >> For i[34567]86-*-linux* and x86_64-*-linux* targets, config.gcc assumes >> modern glibc and set default_gnu_indirect_function to yes. That is wrong >> for i[34567]86-*-linux-android* and

Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread H.J. Lu
On Fri, Nov 14, 2014 at 7:10 AM, Alexander Ivchenko wrote: > should we also change this comment in gcc/configure? > > --enable-gnu-indirect-function > enable the use of the @gnu_indirect_function to > glibc systems That will be a separate issu

Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread Alexander Ivchenko
should we also change this comment in gcc/configure? --enable-gnu-indirect-function enable the use of the @gnu_indirect_function to glibc systems So, if the patch that I sent for removing linux_has_ifunc_p is approved, we will just add "--en

Re: PATCH: Don't assume modern glibc for x86 Android targets

2014-11-14 Thread H.J. Lu
On Thu, Nov 13, 2014 at 09:32:07PM -0800, H.J. Lu wrote: > For i[34567]86-*-linux* and x86_64-*-linux* targets, config.gcc assumes > modern glibc and set default_gnu_indirect_function to yes. That is wrong > for i[34567]86-*-linux-android* and x86_64-*-linux-android* targets. > This patch fixes it

PATCH: Don't assume modern glibc for x86 Android targets

2014-11-13 Thread H.J. Lu
For i[34567]86-*-linux* and x86_64-*-linux* targets, config.gcc assumes modern glibc and set default_gnu_indirect_function to yes. That is wron for i[34567]86-*-linux-android* and and x86_64-*-linux-android* targets. This patch fixes it. Tested on Linux/x86-64, Linux/ia32 and cross-teste for i686