Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-20 Thread Richard Henderson
On 03/19/2011 08:29 AM, H.J. Lu wrote: > PR rtl-optimization/47502 > * gcc.target/i386/pr47502-1.c: New. > * gcc.target/i386/pr47502-2.c: Likewise. Ok. r~

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-19 Thread H.J. Lu
On Fri, Mar 18, 2011 at 3:39 PM, Richard Henderson wrote: > On 03/18/2011 02:51 PM, H.J. Lu wrote: >> See analysis in: >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47502 > > You're patching the wrong place.  See can_combine_p, > which can test for specific sources, rather than > cant_combine_

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-18 Thread Richard Henderson
On 03/18/2011 02:51 PM, H.J. Lu wrote: > See analysis in: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47502 You're patching the wrong place. See can_combine_p, which can test for specific sources, rather than cant_combine_insn_p which has no access to sources. r~

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-18 Thread H.J. Lu
On Fri, Mar 18, 2011 at 2:05 PM, Richard Henderson wrote: > On 03/18/2011 01:56 PM, H.J. Lu wrote: >> On Fri, Mar 18, 2011 at 12:51 PM, Eric Botcazou >> wrote: Is this patch OK for trunk? >>> >>> This has always worked for the other ports AFAIK so I don't think we should >>> disable it with

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-18 Thread Richard Henderson
On 03/18/2011 01:56 PM, H.J. Lu wrote: > On Fri, Mar 18, 2011 at 12:51 PM, Eric Botcazou wrote: >>> Is this patch OK for trunk? >> >> This has always worked for the other ports AFAIK so I don't think we should >> disable it without evaluating the impact on them. If reload has so many >> problems

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-18 Thread H.J. Lu
On Fri, Mar 18, 2011 at 12:51 PM, Eric Botcazou wrote: >> Is this patch OK for trunk? > > This has always worked for the other ports AFAIK so I don't think we should > disable it without evaluating the impact on them.  If reload has so many > problems with x32, maybe more fundamental changes shoul

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-18 Thread Eric Botcazou
> Is this patch OK for trunk? This has always worked for the other ports AFAIK so I don't think we should disable it without evaluating the impact on them. If reload has so many problems with x32, maybe more fundamental changes should be made to the x86 back-end to support it. -- Eric Botcaz

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-17 Thread H.J. Lu
On Thu, Mar 17, 2011 at 8:28 PM, Geert Bosch wrote: > > On Mar 17, 2011, at 20:35, H.J. Lu wrote: > >>> -     substitutions of likely-spilled regs, reload might die. >>> +     substitutions of likely-spilled regs, reload might die.  Never >>> +     combine asm statement. >> > This has to be "state

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-17 Thread Geert Bosch
On Mar 17, 2011, at 20:35, H.J. Lu wrote: >> - substitutions of likely-spilled regs, reload might die. >> + substitutions of likely-spilled regs, reload might die. Never >> + combine asm statement. > This has to be "statements", a plural. -Geert

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-17 Thread H.J. Lu
Hi Eric, Is this patch OK for trunk? Thanks. H.J. --- On Thu, Jan 27, 2011 at 6:14 PM, H.J. Lu wrote: > It is a bad idea to combine asm statement.  This patch disallows it. > Any comments? > > Thanks. > > > H.J. > --- > commit a11b95180e53d3a0bc3eabad5594859cea7c3334 > Author: H.J. Lu > Date: