Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2019-01-18 Thread Christophe Lyon
On Fri, 18 Jan 2019 at 13:52, Rainer Orth wrote: > > Hi Jason, > > > On 1/15/19 12:59 PM, Joseph Myers wrote: > >> On Tue, 15 Jan 2019, Jason Merrill wrote: > >> > >>> I actually incorporated the C++ part of these changes into yesterday's > >>> commit, > >>> using Martin's first suggestion.

Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2019-01-18 Thread Rainer Orth
Hi Jason, > On 1/15/19 12:59 PM, Joseph Myers wrote: >> On Tue, 15 Jan 2019, Jason Merrill wrote: >> >>> I actually incorporated the C++ part of these changes into yesterday's >>> commit, >>> using Martin's first suggestion. Here's the adjusted C patch, which I'd >>> like >>> a C maintainer to

Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2019-01-17 Thread Joseph Myers
On Thu, 17 Jan 2019, Jason Merrill wrote: > This updated patch removes {short ,}unsigned int from the expected > diagnostics. And also improves error_init to accept additional arguments, > like pedwarn_init already does. This version is OK. -- Joseph S. Myers jos...@codesourcery.com

Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2019-01-17 Thread Jason Merrill
On 1/15/19 12:59 PM, Joseph Myers wrote: On Tue, 15 Jan 2019, Jason Merrill wrote: I actually incorporated the C++ part of these changes into yesterday's commit, using Martin's first suggestion. Here's the adjusted C patch, which I'd like a C maintainer to approve. The front-end changes are

Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2019-01-15 Thread Joseph Myers
On Tue, 15 Jan 2019, Jason Merrill wrote: > I actually incorporated the C++ part of these changes into yesterday's commit, > using Martin's first suggestion. Here's the adjusted C patch, which I'd like > a C maintainer to approve. The front-end changes are OK. However, in the testcase changes,

Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2019-01-15 Thread Marek Polacek
On Tue, Jan 15, 2019 at 10:15:22AM -0500, Jason Merrill wrote: > On 1/14/19 11:09 PM, Tom Honermann wrote: > > On 1/4/19 7:25 PM, Martin Sebor wrote: > > > On 12/27/18 1:49 PM, Tom Honermann wrote: > > > > As requested by Jason in the review of the P0482 (char8_t) core > > > > language changes,

Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2019-01-15 Thread Jason Merrill
On 1/14/19 11:09 PM, Tom Honermann wrote: On 1/4/19 7:25 PM, Martin Sebor wrote: On 12/27/18 1:49 PM, Tom Honermann wrote: As requested by Jason in the review of the P0482 (char8_t) core language changes, this patch includes updates to the error messages emitted for ill-formed cases of array

Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2019-01-14 Thread Tom Honermann
On 1/4/19 7:25 PM, Martin Sebor wrote: On 12/27/18 1:49 PM, Tom Honermann wrote: As requested by Jason in the review of the P0482 (char8_t) core language changes, this patch includes updates to the error messages emitted for ill-formed cases of array initialization with a string literal. 

Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2019-01-04 Thread Martin Sebor
On 12/27/18 1:49 PM, Tom Honermann wrote: As requested by Jason in the review of the P0482 (char8_t) core language changes, this patch includes updates to the error messages emitted for ill-formed cases of array initialization with a string literal.  With these changes, error messages that

PATCH: Updated error messages for ill-formed cases of array initialization by string literal

2018-12-27 Thread Tom Honermann
As requested by Jason in the review of the P0482 (char8_t) core language changes, this patch includes updates to the error messages emitted for ill-formed cases of array initialization with a string literal. With these changes, error messages that previously looked something like these: -