Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 19 October 2016 at 20:43, Aldy Hernandez wrote: > >>> OK for the trunk whenever you're ready. >>> >>> jeff >> >> >> You are too fast for me :-) >> I do not have the build trees for all the configurations ready for >> manual testing... >> So, I just merged the initial patch

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

OK for the trunk whenever you're ready. jeff You are too fast for me :-) I do not have the build trees for all the configurations ready for manual testing... So, I just merged the initial patch and the 2nd one, and started a validation job to make sure the 2nd patch fixes all the regressions

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 19 October 2016 at 17:55, Jeff Law wrote: > On 10/19/2016 09:32 AM, Aldy Hernandez wrote: >> >> On 10/19/2016 09:16 AM, Eric Botcazou wrote: m68k-suse-linux >>> >>> >>> visium-elf too. >>> >> >> The attached patch fixes the failures on m68k-suse-linux, visium-elf, >>

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 10/19/2016 09:32 AM, Aldy Hernandez wrote: On 10/19/2016 09:16 AM, Eric Botcazou wrote: m68k-suse-linux visium-elf too. The attached patch fixes the failures on m68k-suse-linux, visium-elf, and arm-eabi. There were a few problems. One problem is that on lp64 targets (where

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

> This fixes both tests on m68k. Likewise on Visium. -- Eric Botcazou

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On Okt 19 2016, Aldy Hernandez wrote: > commit 32b629dcab7b78e8181146338c4b077f1d55a0bf > Author: Aldy Hernandez > Date: Wed Oct 19 11:24:44 2016 -0400 > > * gcc.dg/Walloca-1.c: Adjust test for !lp64 targets. > * gcc.dg/Walloca-2.c: Same. This

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

> I have committed the attached patch as mostly obvious :). Thanks! -- Eric Botcazou

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 10/19/2016 09:16 AM, Eric Botcazou wrote: m68k-suse-linux visium-elf too. The attached patch fixes the failures on m68k-suse-linux, visium-elf, and arm-eabi. There were a few problems. One problem is that on lp64 targets (where sizeof(size_t) != sizeof(int)), the warning is slightly

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 10/19/2016 09:24 AM, Eric Botcazou wrote: It seems to me that there is a precedence for -W type tests to start with a capital letter, as opposed to a lowercase letter: $ cd gcc.dg $ ls W[a-z]* |wc 280 2805816 Do you think it would perhaps be reasonable to rename all of them to

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

> It's unclear from your response whether you want to do this or want me > to do it. In the interest of being lazy, I'll let you do it :). I guess this wasn't really decided in my mind either. ;-) > p.s. If OTOH, you want me to do it, let me know. Yes, please do, thanks in advance. -- Eric

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 10/19/2016 09:24 AM, Eric Botcazou wrote: It seems to me that there is a precedence for -W type tests to start with a capital letter, as opposed to a lowercase letter: $ cd gcc.dg $ ls W[a-z]* |wc 280 2805816 Do you think it would perhaps be reasonable to rename all of them to

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

> It seems to me that there is a precedence for -W type tests to start > with a capital letter, as opposed to a lowercase letter: > > $ cd gcc.dg > $ ls W[a-z]* |wc > 280 2805816 > > Do you think it would perhaps be reasonable to rename all of them to > uppercase? Yes, I agree that

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

> m68k-suse-linux visium-elf too. -- Eric Botcazou

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On Okt 19 2016, Aldy Hernandez wrote: > On 10/19/2016 06:45 AM, Andreas Schwab wrote: >> FAIL: gcc.dg/Walloca-1.c (test for warnings, line 26) >> FAIL: gcc.dg/Walloca-1.c (test for excess errors) >> Excess errors: >>

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 10/19/2016 06:45 AM, Andreas Schwab wrote: FAIL: gcc.dg/Walloca-1.c (test for warnings, line 26) FAIL: gcc.dg/Walloca-1.c (test for excess errors) Excess errors: /daten/aranym/gcc/gcc-20161019/gcc/testsuite/gcc.dg/Walloca-1.c:26:5: warning: unbounded use of 'alloca' [-Walloca-larger-than=]

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 10/19/2016 03:08 AM, Eric Botcazou wrote: My apologies for the delay. I have finally committed this patch. Before doing so, I merged with trunk and re-tested (x86-64 Linux) just in case. There were no regressions. Can you rename the testcases? Git doesn't like the names: *** These

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 19 October 2016 at 12:45, Andreas Schwab wrote: > FAIL: gcc.dg/Walloca-1.c (test for warnings, line 26) > FAIL: gcc.dg/Walloca-1.c (test for excess errors) > Excess errors: > /daten/aranym/gcc/gcc-20161019/gcc/testsuite/gcc.dg/Walloca-1.c:26:5: > warning: unbounded use of

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

FAIL: gcc.dg/Walloca-1.c (test for warnings, line 26) FAIL: gcc.dg/Walloca-1.c (test for excess errors) Excess errors: /daten/aranym/gcc/gcc-20161019/gcc/testsuite/gcc.dg/Walloca-1.c:26:5: warning: unbounded use of 'alloca' [-Walloca-larger-than=] FAIL: gcc.dg/Walloca-2.c (test for warnings,

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

> My apologies for the delay. I have finally committed this patch. > Before doing so, I merged with trunk and re-tested (x86-64 Linux) just > in case. There were no regressions. Can you rename the testcases? Git doesn't like the names: *** These collisions happen when the name of two or more

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 09/13/2016 04:28 PM, Jeff Law wrote: On 08/19/2016 08:58 AM, Aldy Hernandez wrote: I'd just drop the /*strict_mode_p*/ comment in both places it appears in your patch's change to passes.def. I think we've generally frowned on those embedded comments, even though some have snuck in. I've

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 08/19/2016 08:58 AM, Aldy Hernandez wrote: I'd just drop the /*strict_mode_p*/ comment in both places it appears in your patch's change to passes.def. I think we've generally frowned on those embedded comments, even though some have snuck in. I've seen a lot of embedded comments

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 08/04/2016 12:37 PM, Jeff Law wrote: [ughhh, one more time but with actual content] On 07/27/2016 03:01 AM, Aldy Hernandez wrote: Just in case this got lost in noise, since I know there was a lot of back and forth between Martin Sebor and I. This is the last iteration. Tested on x86-64

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 08/19/2016 05:35 AM, Aldy Hernandez wrote: On 08/04/2016 12:37 PM, Jeff Law wrote: On 07/27/2016 03:01 AM, Aldy Hernandez wrote: Just in case this got lost in noise, since I know there was a lot of back and forth between Martin Sebor and I. This is the last iteration. Tested on x86-64

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

On 07/27/2016 03:01 AM, Aldy Hernandez wrote: Just in case this got lost in noise, since I know there was a lot of back and forth between Martin Sebor and I. This is the last iteration. Tested on x86-64 Linux. OK for trunk? curr gcc/ * Makefile.in (OBJS): Add

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

Hi Aldy, > Just in case this got lost in noise, since I know there was a lot of back > and forth between Martin Sebor and I. > > This is the last iteration. > > Tested on x86-64 Linux. > > OK for trunk? > > gcc/ > > * Makefile.in (OBJS): Add gimple-ssa-warn-walloca.o. > * passes.def:

PING: new pass to warn on questionable uses of alloca() and VLAs

Just in case this got lost in noise, since I know there was a lot of back and forth between Martin Sebor and I. This is the last iteration. Tested on x86-64 Linux. OK for trunk? gcc/ * Makefile.in (OBJS): Add gimple-ssa-warn-walloca.o. * passes.def: Add two instances of