Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-29 Thread Hongyu Wang via Gcc-patches
Thanks for your review! I'll ask Hongtao to check-in the patch for me. Uros Bizjak 于2020年10月29日周四 下午4:08写道: > > On Thu, Oct 29, 2020 at 7:52 AM Hongyu Wang wrote: > > > > Hi Uros, > > > > > is there a reason to introduce all these (with corresponding changes)? > > > SSE options live in ISA

Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-29 Thread Uros Bizjak via Gcc-patches
On Thu, Oct 29, 2020 at 7:52 AM Hongyu Wang wrote: > > Hi Uros, > > > is there a reason to introduce all these (with corresponding changes)? > > SSE options live in ISA bitmap, so it is kind of strange you need to > > handle them in ISA2 bitmap. Option handling is not exactly my area, > > please

Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-29 Thread Hongyu Wang via Gcc-patches
Hi Uros, > is there a reason to introduce all these (with corresponding changes)? > SSE options live in ISA bitmap, so it is kind of strange you need to > handle them in ISA2 bitmap. Option handling is not exactly my area, > please ask HJ to comment and review this part. As Hongtao said, this

Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-28 Thread Hongtao Liu via Gcc-patches
On Wed, Oct 28, 2020 at 8:24 PM Uros Bizjak wrote: > > On Wed, Oct 28, 2020 at 10:54 AM Hongyu Wang wrote: > > > > Hi Uros, > > > > Thanks for the example. We've update the patterns with new expanders > > and predicates like vzeroall. > > Now the generated insn for "encodekey128u32" is like > >

Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-28 Thread Uros Bizjak via Gcc-patches
On Wed, Oct 28, 2020 at 10:54 AM Hongyu Wang wrote: > > Hi Uros, > > Thanks for the example. We've update the patterns with new expanders > and predicates like vzeroall. > Now the generated insn for "encodekey128u32" is like > > (insn 7 6 8 2 (parallel [ > (set (reg:SI 84 [ ]) >

Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-28 Thread Hongyu Wang via Gcc-patches
Hi Uros, Thanks for the example. We've update the patterns with new expanders and predicates like vzeroall. Now the generated insn for "encodekey128u32" is like (insn 7 6 8 2 (parallel [ (set (reg:SI 84 [ ]) (unspec_volatile:SI [ (reg:SI 85)

Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-21 Thread Uros Bizjak via Gcc-patches
On Wed, Oct 21, 2020 at 1:48 PM Uros Bizjak wrote: > > On Wed, Oct 21, 2020 at 11:11 AM Hongyu Wang wrote: > > > > Hi, > > > > > IIRC, adding a new regclass is O(n^2), so it should be avoided. I > > > think that the new patterns should follow the same path as vzeroall > > > and vzeroupper

Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-21 Thread Uros Bizjak via Gcc-patches
On Wed, Oct 21, 2020 at 11:11 AM Hongyu Wang wrote: > > Hi, > > > IIRC, adding a new regclass is O(n^2), so it should be avoided. I > > think that the new patterns should follow the same path as vzeroall > > and vzeroupper patterns, where we emit the pattern with explicit hard > > regs. > > > >

Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-21 Thread Hongyu Wang via Gcc-patches
Hi, > IIRC, adding a new regclass is O(n^2), so it should be avoided. I > think that the new patterns should follow the same path as vzeroall > and vzeroupper patterns, where we emit the pattern with explicit hard > regs. > > BTW: We do have SSE_FIRST_REG class, but this class was added to solve

Re: PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-14 Thread Uros Bizjak via Gcc-patches
Hello! > This patch is about to support Intel Key Locker extension. > > Key Locker provides a mechanism to encrypt and decrypt data with an AES key without having access to the raw key value. > > For more details, please refer to

PING [PATCH] Enable GCC support for Intel Key Locker extension

2020-10-12 Thread Hongyu Wang via Gcc-patches
Hongyu Wang 于2020年9月21日周一 下午1:30写道: > > Hi: > > This patch is about to support Intel Key Locker extension. > > Key Locker provides a mechanism to encrypt and decrypt data with an AES key without having access to the raw key value. > > For more details, please refer to