Re: PING -- [PATCH, fortran] PR 85982 -- ICE in resolve_component

2020-04-02 Thread Fritz Reese via Gcc-patches
Tobias, Thank you for the information. I didn't think about translations. I'll post a new version and commit shortly. Cheers, Fritz On Thu, Apr 2, 2020 at 3:50 AM Tobias Burnus wrote: > > In principle, I like the patch. However, I think one should > replace > > gfc_error ("Attribute at %L is n

Re: PING -- [PATCH, fortran] PR 85982 -- ICE in resolve_component

2020-04-02 Thread Tobias Burnus
In principle, I like the patch. However, I think one should replace gfc_error ("Attribute at %L is not allowed in a %s definition", …, state_name by something like: bool is_type = gfc_current_state () == COMP_DERIVED; gfc_error (is_type ? G_("Attribute at %L is not allowed in a TYPE d

Re: PING -- [PATCH, fortran] PR 85982 -- ICE in resolve_component

2020-04-01 Thread Fritz Reese via Gcc-patches
On Wed, Apr 1, 2020 at 1:19 PM Fritz Reese wrote: [...] > is still good. Is this OK to commit to trunk and for backport? I'd > like to port as far back as 7. I realized 7 branch is closed. I would backport to 8. > gcc/testsuite/ChangeLog: > 2020-04-01 Fritz Reese > >PR fortran/85982 >

PING -- [PATCH, fortran] PR 85982 -- ICE in resolve_component

2020-04-01 Thread Fritz Reese via Gcc-patches
This simple patch was submitted some time ago (over 1 year), but got lost without review. I have lately rebased and tested, and the patch is still good. Is this OK to commit to trunk and for backport? I'd like to port as far back as 7. --- Fritz Reese gcc/ChangeLog: 2020-04-01 Fritz Reese