Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-30 Thread Thomas Schwinge
Hi! On Tue, 29 Sep 2015 10:18:14 +0200, Jakub Jelinek wrote: > On Mon, Sep 28, 2015 at 11:39:10AM +0200, Thomas Schwinge wrote: > > On Fri, 11 Sep 2015 17:43:49 +0200, Jakub Jelinek wrote: > > > So, do I understand well that you'll call

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-29 Thread Jakub Jelinek
On Mon, Sep 28, 2015 at 11:39:10AM +0200, Thomas Schwinge wrote: > Hi! > > On Fri, 11 Sep 2015 17:43:49 +0200, Jakub Jelinek wrote: > > So, do I understand well that you'll call GOMP_set_offload_targets from > > construct[ors] of all shared libraries (and the binary) that

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-28 Thread Thomas Schwinge
Hi! On Fri, 11 Sep 2015 17:43:49 +0200, Jakub Jelinek wrote: > So, do I understand well that you'll call GOMP_set_offload_targets from > construct[ors] of all shared libraries (and the binary) that contain offloaded > code? If yes, that is surely going to fail the assertions

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Joseph Myers
On Fri, 11 Sep 2015, Jakub Jelinek wrote: > On Fri, Sep 11, 2015 at 03:26:04PM +, Joseph Myers wrote: > > On Fri, 11 Sep 2015, Bernd Schmidt wrote: > > > > > I expect you know best what to do in the OpenACC testsuite driver, but you > > > might want to run the libgomp.exp parts by Jakub. If

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Bernd Schmidt
On 09/11/2015 04:23 PM, Joseph Myers wrote: On Thu, 10 Sep 2015, Bernd Schmidt wrote: On 09/10/2015 03:41 PM, Joseph Myers wrote: Ping^2. This patch is still pending review. No fundamental objections, but I have some questions.

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Joseph Myers
On Thu, 10 Sep 2015, Bernd Schmidt wrote: > On 09/10/2015 03:41 PM, Joseph Myers wrote: > > Ping^2. This patch > > is still > > pending review. > > No fundamental objections, but I have some questions. Cuold you describe > what the

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Joseph Myers
On Fri, 11 Sep 2015, Bernd Schmidt wrote: > I expect you know best what to do in the OpenACC testsuite driver, but you > might want to run the libgomp.exp parts by Jakub. If the testsuite parts are > independent of the rest of the patch, please repost them separately. Jakub? The testsuite

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-11 Thread Jakub Jelinek
On Fri, Sep 11, 2015 at 03:26:04PM +, Joseph Myers wrote: > On Fri, 11 Sep 2015, Bernd Schmidt wrote: > > > I expect you know best what to do in the OpenACC testsuite driver, but you > > might want to run the libgomp.exp parts by Jakub. If the testsuite parts are > > independent of the rest

Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-10 Thread Joseph Myers
Ping^2. This patch is still pending review. -- Joseph S. Myers jos...@codesourcery.com

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-10 Thread Bernd Schmidt
On 09/10/2015 03:41 PM, Joseph Myers wrote: > Ping^2. This patch > is still > pending review. No fundamental objections, but I have some questions. Cuold you describe what the handling of flags/lang_mask accomplishes in this patch?