RE: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

Committed revision 214211.

Re: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

On Mon, Aug 18, 2014 at 6:48 PM, VandeVondele Joost joost.vandevond...@mat.ethz.ch wrote: ping ? https://gcc.gnu.org/ml/fortran/2014-05/msg00162.html Ok, again. If Dominique comes up with some reason why the patch should be modified, it can be done then. AFAICT your patch is better than the

RE: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

Thanks, can somebody with svn write access commit ?

Re: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

On Tue, Aug 19, 2014 at 1:07 PM, VandeVondele Joost joost.vandevond...@mat.ethz.ch wrote: Thanks, can somebody with svn write access commit ? Please get yourself write-after-approval access per instructions at https://gcc.gnu.org/svnwrite.html . You can use me as your sponsor. Thanks. --

RE: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

ping ? https://gcc.gnu.org/ml/fortran/2014-05/msg00162.html

RE: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

Dominque, after Janne's OK, and FX judgement, I wonder if you have reached a conclusion. If so, the fsf assignment is now complete, and the patch could be applied. Joost Ok for trunk. Thanks! Please don't rush! The behavior of -fno-signed-zeros -fno-trapping-math implying associative math

RE: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

I have now verified that both new testcases indeed pass with gcc version 4.6.0 20100520 (experimental) [trunk revision 159620] (GCC) that is the revision where Tobias enabled associative math by default. So that this patch fixes a regression.

Re: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

On Thu, Jun 5, 2014 at 3:54 PM, VandeVondele Joost joost.vandevond...@mat.ethz.ch wrote: I have now verified that both new testcases indeed pass with gcc version 4.6.0 20100520 (experimental) [trunk revision 159620] (GCC) that is the revision where Tobias enabled associative math by default.

Re: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

Ok for trunk. Thanks! Please don't rush! The behavior of -fno-signed-zeros -fno-trapping-math implying associative math has been changed (as in reverted) between r165758 (implied associative math) and r165930 (lost associative math). AFAICT it could be due to 165823. Investigating! I am also

RE: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

Why do you want -fno-math-errno to be the default for gfortran? because it was with rth's commit? This makes sense also because errno is a variable that is defined for C, and not accessible from Fortran. Why would you want -fmath-errno to be the default ? if (flag_associative_math == -1)

Re: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

Why do you want -fno-math-errno to be the default for gfortran? AFAICT such default is not documented and the flag works (checked on your test gfortran.dg/errnocheck_1.f90). It should be the default, and it used to be. Fortran doesn’t care about math routines setting errno (its existence is

Re: [PATCH, Fortan] fix initialization of flag_errno_math and flag_associative_math

Hi Joost, Why do you want -fno-math-errno to be the default for gfortran? AFAICT such default is not documented and the flag works (checked on your test gfortran.dg/errnocheck_1.f90). For -fassociative-math, the manual says For Fortran the option is automatically enabled when both