RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-10-07 Thread Moore, Catherine
> -Original Message- > From: Steve Ellcey [mailto:sell...@imgtec.com] > Sent: Tuesday, October 06, 2015 6:03 PM > To: Moore, Catherine > Cc: Matthew Fortune; GCC Patches > Subject: RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI > > On Tue, 2015-10-

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-10-06 Thread Steve Ellcey
On Tue, 2015-10-06 at 12:02 +, Moore, Catherine wrote: > > Moore, Catherine writes: > > > The patch itself looks good, but the tests that you added need a little > > > more > > work. Here is a new patch for just the tests. I added NOMIPS16 and the -mabi=32 flag

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-10-06 Thread Matthew Fortune
Moore, Catherine writes: > The patch itself looks good, but the tests that you added need a little more > work. > > I tested with the mips-sde-elf-lite configuration and I'm seeing failures for > many > options. The main failure mode seems to be that the stack is

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-10-06 Thread Moore, Catherine
> -Original Message- > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] > Sent: Tuesday, October 06, 2015 4:39 AM > To: Moore, Catherine; Steve Ellcey > Cc: GCC Patches > Subject: RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI > > Moore,

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-10-05 Thread Moore, Catherine
> -Original Message- > From: Steve Ellcey [mailto:sell...@imgtec.com] > Sent: Monday, October 05, 2015 1:16 PM > To: Moore, Catherine > Cc: Matthew Fortune; GCC Patches > Subject: RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI > > On Mon, 2015-09-

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-10-05 Thread Steve Ellcey
On Mon, 2015-09-28 at 22:10 +, Moore, Catherine wrote: > Hi Steve, I'm sorry for the delay in reviewing this patch. > Some changes have been committed upstream (see revision #227941) that will > require updates to this patch. > Please post the update for review. Other comments are embedded.

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-09-28 Thread Moore, Catherine
> -Original Message- > From: Steve Ellcey [mailto:sell...@imgtec.com] > Sent: Friday, September 11, 2015 2:06 PM > To: Matthew Fortune > Cc: GCC Patches; Moore, Catherine > Subject: RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI > > On Fri, 2

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-09-11 Thread Steve Ellcey
On Fri, 2015-09-04 at 01:40 -0700, Matthew Fortune wrote: > A few comments below. I found some of the comments a bit hard to parse but > have > not attempted any rewording. I'd like Catherine to comment too as I have > barely > any experience at the gimple level to know if this accounts for any

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-09-04 Thread Matthew Fortune
Steve Ellcey writes: > Here is an update of my MIPS frame header optimization patch. This is > actually only one part of the patch but I would like to get this approved > and checked in before proceeding with the second half. > > The O32 ABI on MIPS requires that