On Thu, Nov 13, 2014 at 7:57 PM, Ulrich Weigand uweig...@de.ibm.com wrote:
Richard Henderson wrote:
On 11/12/2014 09:41 PM, Ulrich Weigand wrote:
* optabs.c (prepare_operand): Gracefully fail if the mode of X
does not match the operand mode expected by the insn pattern.
This is ok.
: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4 (fix s390
build)
On 11/06/2014 08:44 AM, Zhenqiang Chen wrote:
Hi,
The patch add runtime check to fix s390 build fail
(https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00050.html
Richard Henderson wrote:
On 11/12/2014 09:41 PM, Ulrich Weigand wrote:
* optabs.c (prepare_operand): Gracefully fail if the mode of X
does not match the operand mode expected by the insn pattern.
This is ok.
I've checked this in now, thanks.
I wondered whether s390 benefit from
Zhenqiang Chen wrote:
Function noce_emit_store_flag tries to generate instruction to store flag by
emit_store_flag for general_operand. For s390, CCU is a general _operand,
but can not match cstorecc4, then it tries to generate a register move
instruction from CCU to CCZ1, which will trigger
-Original Message-
From: Richard Henderson [mailto:r...@redhat.com]
Sent: Thursday, November 06, 2014 4:23 PM
To: Zhenqiang Chen; 'Jan-Benedict Glaw'; Hartmut Penner; Ulrich Weigand;
Andreas Krebbel
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, ifcvt] Allow CC mode
On 11/13/2014 08:49 AM, Zhenqiang Chen wrote:
After adding HAVE_cbranchcc4, we can just use HAVE_cbranchcc4. No need to
add a local variable allow_cc_mode.
Here is the updated patch.
This is ok.
Since I've already approved Ulrich's s390 fix, there should not be a
problem there for long.
-Original Message-
From: Ulrich Weigand [mailto:uweig...@de.ibm.com]
Sent: Friday, November 07, 2014 12:11 AM
To: Richard Henderson
Cc: Zhenqiang Chen; 'Jan-Benedict Glaw'; Hartmut Penner; Andreas Krebbel;
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, ifcvt] Allow CC mode
Richard Henderson wrote:
On 11/06/2014 05:10 PM, Ulrich Weigand wrote:
+ /* For s390, CC REG is general_operand. But cstorecc4
only
+ handles CCZ1, which can not handle others like CCU.
*/
+ || GET_MODE_CLASS (GET_MODE (XEXP (cond, 0))) ==
On 11/06/2014 08:44 AM, Zhenqiang Chen wrote:
Hi,
The patch add runtime check to fix s390 build fail
(https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00050.html).
And there is additional code to workaround s390 cstorecc4 issue.
Bootstrap and no make check regression on X86-64.
Build
Richard Henderson wrote:
On 11/06/2014 08:44 AM, Zhenqiang Chen wrote:
Hi,
The patch add runtime check to fix s390 build fail
(https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00050.html).
And there is additional code to workaround s390 cstorecc4 issue.
Bootstrap and no make check
On 11/06/2014 05:10 PM, Ulrich Weigand wrote:
+/* For s390, CC REG is general_operand. But cstorecc4
only
+ handles CCZ1, which can not handle others like CCU.
*/
+ || GET_MODE_CLASS (GET_MODE (XEXP (cond, 0))) == MODE_CC);
I'd like to know
11 matches
Mail list logo
