Re: [PATCH] Implement P0966 std::string::reserve should not shrink

2020-08-10 Thread Jonathan Wakely via Gcc-patches
On 10/08/20 10:22 +0100, Jozef Lawrynowicz wrote: Hi, On Thu, Aug 06, 2020 at 06:48:36PM +, Jonathan Wakely via Gcc-patches wrote: I've now pushed that combined patch to master. In libstdc++-v3/include/bits/basic_string.tcc around line 1190, there's a missing "#if __cpp_exceptions" test

Re: [PATCH] Implement P0966 std::string::reserve should not shrink

2020-08-10 Thread Jozef Lawrynowicz
Hi, On Thu, Aug 06, 2020 at 06:48:36PM +, Jonathan Wakely via Gcc-patches wrote: > > I've now pushed that combined patch to master. In libstdc++-v3/include/bits/basic_string.tcc around line 1190, there's a missing "#if __cpp_exceptions" test for the try/catch block that was added by this

Re: [PATCH] Implement P0966 std::string::reserve should not shrink

2020-08-07 Thread Jonathan Wakely via Gcc-patches
On 07/08/20 15:17 +0100, Jonathan Wakely via Libstdc++ wrote: On 07/08/20 14:48 +0100, Jonathan Wakely wrote: On 07/08/20 14:02 +0200, Rainer Orth wrote: Hi Jonathan, Here's the combined patch, based on your original with my proposed simplifications applied. I've now pushed that combined

Re: [PATCH] Implement P0966 std::string::reserve should not shrink

2020-08-07 Thread Jonathan Wakely via Gcc-patches
On 07/08/20 14:48 +0100, Jonathan Wakely wrote: On 07/08/20 14:02 +0200, Rainer Orth wrote: Hi Jonathan, Here's the combined patch, based on your original with my proposed simplifications applied. I've now pushed that combined patch to master. Sorry it took so long to integrate your

Re: [PATCH] Implement P0966 std::string::reserve should not shrink

2020-08-07 Thread Jonathan Wakely via Gcc-patches
On 07/08/20 14:02 +0200, Rainer Orth wrote: Hi Jonathan, Here's the combined patch, based on your original with my proposed simplifications applied. I've now pushed that combined patch to master. Sorry it took so long to integrate your changes, but thanks very much for the contribution to

Re: [PATCH] Implement P0966 std::string::reserve should not shrink

2020-08-07 Thread Rainer Orth
Hi Jonathan, >>Here's the combined patch, based on your original with my proposed >>simplifications applied. > > I've now pushed that combined patch to master. > > Sorry it took so long to integrate your changes, but thanks very much > for the contribution to GCC! it seems this patch caused

Re: [PATCH] Implement P0966 std::string::reserve should not shrink

2020-08-06 Thread Jonathan Wakely via Gcc-patches
On 30/07/20 16:39 +0100, Jonathan Wakely wrote: On 30/07/20 15:29 +0100, Jonathan Wakely wrote: On 12/05/19 21:22 +, Andrew Luo wrote: It's been a while, but thought I'd check in again now that GCC 9 has been branched, and master is now on GCC 10. I've merged my changes with the latest

Re: [PATCH] Implement P0966 std::string::reserve should not shrink

2020-07-30 Thread Jonathan Wakely via Gcc-patches
On 30/07/20 15:29 +0100, Jonathan Wakely wrote: On 12/05/19 21:22 +, Andrew Luo wrote: It's been a while, but thought I'd check in again now that GCC 9 has been branched, and master is now on GCC 10. I've merged my changes with the latest code and attached a diff... Let me know if

Re: [PATCH] Implement P0966 std::string::reserve should not shrink

2020-07-30 Thread Jonathan Wakely via Gcc-patches
On 12/05/19 21:22 +, Andrew Luo wrote: It's been a while, but thought I'd check in again now that GCC 9 has been branched, and master is now on GCC 10. I've merged my changes with the latest code and attached a diff... Let me know if there's any thoughts on this. Well I failed to get

RE: [PATCH] Implement P0966 std::string::reserve should not shrink

2019-05-12 Thread Andrew Luo
...@gcc.gnu.org On Behalf Of Andrew Luo Sent: Wednesday, January 23, 2019 5:15 PM To: Jonathan Wakely Cc: libstd...@gcc.gnu.org; gcc-patches@gcc.gnu.org Subject: RE: [PATCH] Implement P0966 std::string::reserve should not shrink Here's an updated diff. Still a work in progress, ran the tests

RE: [PATCH] Implement P0966 std::string::reserve should not shrink

2019-01-23 Thread Andrew Luo
3:26 AM To: Andrew Luo Cc: libstd...@gcc.gnu.org Subject: Re: [PATCH] Implement P0966 std::string::reserve should not shrink On 23/01/19 00:44 +, Andrew Luo wrote: >Thanks for the input. I will make the suggested changes. > >I didn't add a changelog entry yet (which I was plann