Tamar Christina writes:
>> -Original Message-
>> From: Richard Sandiford
>> Sent: Monday, July 12, 2021 11:26 AM
>> To: Tamar Christina
>> Cc: Richard Biener ; nd ; gcc-
>> patc...@gcc.gnu.org
>> Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product
>> where the sign for
> -Original Message-
> From: Richard Sandiford
> Sent: Monday, July 12, 2021 11:26 AM
> To: Tamar Christina
> Cc: Richard Biener ; nd ; gcc-
> patc...@gcc.gnu.org
> Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product
> where the sign for the multiplicant changes.
>
>
Tamar Christina writes:
>> -Original Message-
>> From: Richard Sandiford
>> Sent: Monday, July 12, 2021 10:39 AM
>> To: Tamar Christina
>> Cc: Richard Biener ; nd ; gcc-
>> patc...@gcc.gnu.org
>> Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product
>> where the sign for
> -Original Message-
> From: Richard Sandiford
> Sent: Monday, July 12, 2021 10:39 AM
> To: Tamar Christina
> Cc: Richard Biener ; nd ; gcc-
> patc...@gcc.gnu.org
> Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product
> where the sign for the multiplicant changes.
>
>
Tamar Christina writes:
> Hi,
>
>> Richard Sandiford writes:
>> >> @@ -992,21 +1029,27 @@ vect_recog_dot_prod_pattern (vec_info
>> *vinfo,
>> >>/* FORNOW. Can continue analyzing the def-use chain when this stmt in
>> a phi
>> >> inside the loop (in case we are analyzing an
Hi,
> Richard Sandiford writes:
> >> @@ -992,21 +1029,27 @@ vect_recog_dot_prod_pattern (vec_info
> *vinfo,
> >>/* FORNOW. Can continue analyzing the def-use chain when this stmt in
> a phi
> >> inside the loop (in case we are analyzing an outer-loop). */
> >>
Richard Sandiford writes:
>> @@ -992,21 +1029,27 @@ vect_recog_dot_prod_pattern (vec_info *vinfo,
>>/* FORNOW. Can continue analyzing the def-use chain when this stmt in a
>> phi
>> inside the loop (in case we are analyzing an outer-loop). */
>>vect_unpromoted_value unprom0[2];
Sorry for the slow review.
Just concentrating on tree-vect-patterns.c, as before:
Tamar Christina writes:
> @@ -521,6 +522,9 @@ vect_joust_widened_type (tree type, tree new_type, tree
> *common_type)
>unsigned int precision = MAX (TYPE_PRECISION (*common_type),
>
Ping
> -Original Message-
> From: Gcc-patches bounces+tamar.christina=arm@gcc.gnu.org> On Behalf Of Tamar
> Christina via Gcc-patches
> Sent: Monday, June 14, 2021 1:06 PM
> To: Richard Sandiford
> Cc: gcc-patches@gcc.gnu.org; nd ; Richard Biener
>
> Subject: RE: [PATCH
Hi Richard,
I've attached a new version of the patch with the changes.
I have also added 7 new tests in the testsuite to check the cases you mentioned.
Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
Ok for master?
Thanks,
Tamar
gcc/ChangeLog:
* optabs.def
Sorry for the slow response.
Tamar Christina writes:
> […]
> diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c
> index
> 441d6cd28c4eaded7abd756164890dbcffd2f3b8..82123b96313e6783ea214b9259805d65c07d8858
> 100644
> --- a/gcc/tree-vect-patterns.c
> +++ b/gcc/tree-vect-patterns.c
Hi Richi,
Attached is re-spun patch. tree_nop_conversion_p was very handy in cleaning up
the patch, Thanks!
Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
Ok for master if Richard S has no comments?
Thanks,
Tamar
gcc/ChangeLog:
* optabs.def (usdot_prod_optab): New.
Ping,
Did you have any comments Richard S?
Otherwise I'll proceed with respining according to Richi's comments.
Regards,
Tamar
> -Original Message-
> From: Richard Biener
> Sent: Wednesday, May 26, 2021 9:57 AM
> To: Tamar Christina
> Cc: gcc-patches@gcc.gnu.org; nd ; Richard
On Tue, 25 May 2021, Tamar Christina wrote:
> Hi Richi,
>
> Here's a respun version of the patch.
>
> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
>
> Ok for master?
index
7e3aae5f9c28a49feedc7cc66e8ac0d476b9f28a..13e405edd765dde704c64348d2d0b3cd88f0af7c
100644
---
Hi Richi,
Here's a respun version of the patch.
Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
Ok for master?
Thanks,
Tamar
gcc/ChangeLog:
* optabs.def (usdot_prod_optab): New.
* doc/md.texi: Document it and clarify other dot prod optabs.
*
On Mon, 10 May 2021, Tamar Christina wrote:
>
>
> > -Original Message-
> > From: Richard Biener
> > Sent: Monday, May 10, 2021 12:40 PM
> > To: Tamar Christina
> > Cc: gcc-patches@gcc.gnu.org; nd
> > Subject: RE: [PATCH 1/4]middle-end Vect: Add support for dot-product
> > where the
> -Original Message-
> From: Richard Biener
> Sent: Monday, May 10, 2021 12:40 PM
> To: Tamar Christina
> Cc: gcc-patches@gcc.gnu.org; nd
> Subject: RE: [PATCH 1/4]middle-end Vect: Add support for dot-product
> where the sign for the multiplicant changes.
>
> On Fri, 7 May 2021,
On Fri, 7 May 2021, Tamar Christina wrote:
> Hi Richi,
>
> > -Original Message-
> > From: Richard Biener
> > Sent: Friday, May 7, 2021 12:46 PM
> > To: Tamar Christina
> > Cc: gcc-patches@gcc.gnu.org; nd
> > Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product
> >
Hi Richi,
> -Original Message-
> From: Richard Biener
> Sent: Friday, May 7, 2021 12:46 PM
> To: Tamar Christina
> Cc: gcc-patches@gcc.gnu.org; nd
> Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product
> where the sign for the multiplicant changes.
>
> On Wed, 5 May
On Wed, 5 May 2021, Tamar Christina wrote:
> Hi All,
>
> This patch adds support for a dot product where the sign of the multiplication
> arguments differ. i.e. one is signed and one is unsigned but the precisions
> are
> the same.
>
> #define N 480
> #define SIGNEDNESS_1 unsigned
> #define
20 matches
Mail list logo
