RE: [Patch, MIPS] Cleanup mips header files.

2014-10-08 Thread Steve Ellcey
On Mon, 2014-10-06 at 14:25 -0700, Matthew Fortune wrote: Hi Steve, You're the lucky recipient of my first review so apologies for being slow and cautious... I tried to find a reason why the files were originally separated like this and I can't see anything obvious. I assume you also

RE: [Patch, MIPS] Cleanup mips header files.

2014-10-08 Thread Steve Ellcey
Matthew, I just discovered that I dropped one of the files I changed as part of my MIPS header file cleanup patch and so it did not get checked in. This change was part of my testing, I just didn't include it in the patch I submitted and checked in. Is this (hopefully obvious) change OK for

RE: [Patch, MIPS] Cleanup mips header files.

2014-10-08 Thread Matthew Fortune
2014-10-08 Steve Ellcey sell...@mips.com * config/mips/mti-linux.h (DRIVER_SELF_SPECS): Change LINUX64_DRIVER_SELF_SPECS to LINUX_DRIVER_SELF_SPECS OK. I'd agree with obvious here. Matthew

RE: [Patch, MIPS] Cleanup mips header files.

2014-10-06 Thread Matthew Fortune
Hi Steve, You're the lucky recipient of my first review so apologies for being slow and cautious... I tried to find a reason why the files were originally separated like this and I can't see anything obvious. I assume you also found no reason. Presumably the separation was just to avoid