RE: [Ping] [PATCH, 5/10] aarch64: add ccmp operand predicate

2014-10-27 Thread Zhenqiang Chen
Thanks for the comments. All comments are accepted and the updated patch is attached. -Zhenqiang -Original Message- From: Richard Henderson [mailto:r...@redhat.com] Sent: Saturday, October 11, 2014 11:22 PM To: Zhenqiang Chen; gcc-patches@gcc.gnu.org Subject: Re: [Ping] [PATCH, 5/10

Re: [Ping] [PATCH, 5/10] aarch64: add ccmp operand predicate

2014-10-27 Thread Richard Henderson
On 10/27/2014 12:48 AM, Zhenqiang Chen wrote: Thanks for the comments. All comments are accepted and the updated patch is attached. -Zhenqiang New patch looks good. r~

Re: [Ping] [PATCH, 5/10] aarch64: add ccmp operand predicate

2014-10-11 Thread Richard Henderson
On 09/22/2014 11:44 PM, Zhenqiang Chen wrote: +/* Return true if val can be encoded as a 5-bit unsigned immediate. */ +bool +aarch64_uimm5 (HOST_WIDE_INT val) +{ + return (val (HOST_WIDE_INT) 0x1f) == val; +} This is just silly. +(define_constraint Usn + A constant that can be used