Re: 0005-Part-5.-Add-x86-CET-documentation

2017-09-28 Thread Sandra Loosemore
On 09/27/2017 09:17 AM, Tsimbalist, Igor V wrote: Updated version #3. diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index e52a1ea..accba40 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -5655,6 +5655,14 @@ compiled with the @option{-fcf-protection=branch} option. The

Re: 0005-Part-5.-Add-x86-CET-documentation

2017-09-28 Thread Jeff Law
On 09/27/2017 09:17 AM, Tsimbalist, Igor V wrote: >> > > 0005-Add-x86-CET-documentation.patch > > > From dda22b06a3a5bde9b0dc57585d878db520769510 Mon Sep 17 00:00:00 2001 > From: Igor Tsimbalist > Date: Tue, 4 Jul 2017 13:55:03 +0300 > Subject: [PATCH 5/6] Add x86

Re: 0005-Part-5.-Add-x86-CET-documentation

2017-09-28 Thread Jeff Law
On 09/27/2017 11:01 AM, Joseph Myers wrote: > On Wed, 27 Sep 2017, Florian Weimer wrote: > >> This is part of the ABI GCC implements, so it has to be documented somewhere, >> and not just as part of the GCC source code. >> >> CET is not properly described in the ABI supplement and I don't think

Re: 0005-Part-5.-Add-x86-CET-documentation

2017-09-27 Thread Joseph Myers
On Wed, 27 Sep 2017, Florian Weimer wrote: > This is part of the ABI GCC implements, so it has to be documented somewhere, > and not just as part of the GCC source code. > > CET is not properly described in the ABI supplement and I don't think this > will change, so detailed documentation in the

Re: 0005-Part-5.-Add-x86-CET-documentation

2017-09-27 Thread Sandra Loosemore
On 09/27/2017 02:52 AM, Florian Weimer wrote: On 09/27/2017 05:40 AM, Sandra Loosemore wrote: +@emph{x86 implementation:} when @option{-fcf-protection} option is +specified the compiler inserts an ENDBR instruction at function's +prologue if the function's type does not have the

RE: 0005-Part-5.-Add-x86-CET-documentation

2017-09-27 Thread Tsimbalist, Igor V
u.org > Subject: Re: 0005-Part-5.-Add-x86-CET-documentation > > On 09/26/2017 07:47 AM, Tsimbalist, Igor V wrote: > > Here is a new version of the patch. > > > > diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index > > a374890..a900ed1 100644 > > -

RE: 0005-Part-5.-Add-x86-CET-documentation

2017-09-27 Thread Tsimbalist, Igor V
gt; > Cc: gcc-patches@gcc.gnu.org > Subject: Re: 0005-Part-5.-Add-x86-CET-documentation > > On 09/27/2017 05:40 AM, Sandra Loosemore wrote: > >> > >> +@emph{x86 implementation:} when @option{-fcf-protection} option is > >> +specified the compiler inserts an EN

Re: 0005-Part-5.-Add-x86-CET-documentation

2017-09-27 Thread Florian Weimer
On 09/27/2017 05:40 AM, Sandra Loosemore wrote: +@emph{x86 implementation:} when @option{-fcf-protection} option is +specified the compiler inserts an ENDBR instruction at function's +prologue if the function's type does not have the @code{nocf_check} +attribute and addresses to which indirect

Re: 0005-Part-5.-Add-x86-CET-documentation

2017-09-26 Thread Sandra Loosemore
On 09/26/2017 07:47 AM, Tsimbalist, Igor V wrote: Here is a new version of the patch. diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index a374890..a900ed1 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -5655,6 +5655,13 @@ compiled with the @option{-fcf-protection=branch}

RE: 0005-Part-5.-Add-x86-CET-documentation

2017-09-26 Thread Tsimbalist, Igor V
t; Cc: gcc-patches@gcc.gnu.org > Subject: Re: 0005-Part-5.-Add-x86-CET-documentation > > On 09/20/2017 08:13 AM, Uros Bizjak wrote: > > On Wed, Sep 20, 2017 at 11:20 AM, Tsimbalist, Igor V > > <igor.v.tsimbal...@intel.com> wrote: > >> Uros, could you please review thi

Re: 0005-Part-5.-Add-x86-CET-documentation

2017-09-24 Thread Sandra Loosemore
On 09/20/2017 08:13 AM, Uros Bizjak wrote: On Wed, Sep 20, 2017 at 11:20 AM, Tsimbalist, Igor V wrote: Uros, could you please review this patch as it's a part of x86 specific changes you have reviewed already. Please proofread and spell-check the text. There are

Re: 0005-Part-5.-Add-x86-CET-documentation

2017-09-20 Thread Uros Bizjak
On Wed, Sep 20, 2017 at 11:20 AM, Tsimbalist, Igor V wrote: > Uros, could you please review this patch as it's a part of x86 specific > changes you have reviewed already. Please proofread and spell-check the text. There are grammatical errors, e.g.: +When compiled

RE: 0005-Part-5.-Add-x86-CET-documentation

2017-09-20 Thread Tsimbalist, Igor V
Uros, could you please review this patch as it's a part of x86 specific changes you have reviewed already. Thanks, Igor > -Original Message- > From: Tsimbalist, Igor V > Sent: Tuesday, August 1, 2017 10:57 AM > To: 'gcc-patches@gcc.gnu.org' > Cc: Tsimbalist,