RE: Re: [PATCH] RISC-V: Disallow RVV mode address for any load/store[PR112535]

2023-11-14 Thread Li, Pan2
Committed, thanks Kito. Pan -Original Message- From: Kito Cheng Sent: Wednesday, November 15, 2023 3:36 PM To: juzhe.zh...@rivai.ai Cc: Kito.cheng ; gcc-patches ; jeffreyalaw ; Robin Dapp Subject: Re: Re: [PATCH] RISC-V: Disallow RVV mode address for any load/store[PR112535] LGTM

Re: Re: [PATCH] RISC-V: Disallow RVV mode address for any load/store[PR112535]

2023-11-14 Thread Kito Cheng
LGTM, and yeah, I agree that's a code model issue. On Wed, Nov 15, 2023 at 3:29 PM juzhe.zh...@rivai.ai wrote: > > Yes. > (set (reg:DI) (subreg:DI (reg:V1DI 155) 0)) become vmv.x.s > > So, you will see: > vsetivli zero,1,e64,m1,ta,ma > sb zero,%lo(c)(a2) > vle64.v v1,0(a5) > lbu a5,%lo(b)(a4) > v

Re: Re: [PATCH] RISC-V: Disallow RVV mode address for any load/store[PR112535]

2023-11-14 Thread juzhe.zh...@rivai.ai
Yes. (set (reg:DI) (subreg:DI (reg:V1DI 155) 0)) become vmv.x.s So, you will see: vsetivli zero,1,e64,m1,ta,ma sb zero,%lo(c)(a2) vle64.v v1,0(a5) lbu a5,%lo(b)(a4) vse64.v v1,0(a3) beq a5,zero,.L6 vmv.x.s a5,v1 sw zero,0(a5) I think the codegen is not good. It should be using scalar load/store.