Re: [PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-08 Thread Bernhard Reutner-Fischer
On 6 November 2013 08:04, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 06, 2013 at 02:24:01AM +, Iyer, Balaji V wrote: Fixed patch is attached. The responses to your question are given below. Is this patch OK? Here is the ChangeLog entry: +2013-11-05 Balaji V. Iyer

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-05 Thread Iain Sandoe
hi Balaji sorry for a short reply, but I'm traveling this week, On 4 Nov 2013, at 23:02, Iyer, Balaji V wrote: 2). The C tests are extremely time-consuming (m32/m64) with NO -jxx on the c/l: x86_64-linux (32 cores 2.8G Xeon) : 36m/421m/6m x86_64-darwin12 (8 cores 2.8G Xeon) :

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-05 Thread Jakub Jelinek
Hi! On Mon, Nov 04, 2013 at 11:02:13PM +, Iyer, Balaji V wrote: See my other mail on this topic, the number of different option combinations is just excessive and must be reduced to a reasonable minimum. 2). The C tests are extremely time-consuming (m32/m64) with NO -jxx on the c/l:  

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-05 Thread Jakub Jelinek
On Tue, Nov 05, 2013 at 12:21:04PM +0100, Jakub Jelinek wrote: Tests that many seconds or more on fast machines, especially if you run them 25 times, are simply not appropriate for gcc testsuite, at least not by default. We have run_expensive_tests (from GCC_RUN_EXPENSIVE_TESTS in

[PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-05 Thread Iyer, Balaji V
To: Iyer, Balaji V Cc: Iain Sandoe; Joseph S. Myers; Tobias Burnus; gcc patches Subject: Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp On Tue, Nov 05, 2013 at 12:21:04PM +0100, Jakub Jelinek wrote: Tests that many seconds or more on fast

Re: [PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-05 Thread Jeff Law
On 11/05/13 10:04, Iyer, Balaji V wrote: Hello Jakub et al., I went through all your emails and the patch above will fix the following issues: 1. Bug in the fib.c test case where it should recursively call fib_serial instead of fib() in the serial case. 2. Remove duplicate or unwanted

Re: [PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-05 Thread Jakub Jelinek
On Tue, Nov 05, 2013 at 05:04:21PM +, Iyer, Balaji V wrote: --- gcc.dg/cilk-plus/cilk-plus.exp(revision 204396) +++ gcc.dg/cilk-plus/cilk-plus.exp(working copy) dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] -fcilkplus $ALWAYS_CFLAGS -dg-runtest

RE: [PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-05 Thread Iyer, Balaji V
, November 5, 2013 12:21 PM To: Iyer, Balaji V Cc: Iain Sandoe; Joseph S. Myers; Tobias Burnus; gcc patches Subject: Re: [PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp On Tue, Nov 05, 2013 at 05:04:21PM +, Iyer, Balaji V wrote

Re: [PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-05 Thread Jakub Jelinek
On Wed, Nov 06, 2013 at 02:24:01AM +, Iyer, Balaji V wrote: Fixed patch is attached. The responses to your question are given below. Is this patch OK? Here is the ChangeLog entry: +2013-11-05 Balaji V. Iyer balaji.v.i...@intel.com + + * c-c++-common/cilk-plus/CK/fib.c:

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-04 Thread David Edelsohn
Balaji, I am seeing a large number of libcilkrts failures on AIX. These all are of the form: Executing on host: /tmp/20131103/gcc/xgcc -B/tmp/20131103/gcc/ /nasfarm/edelsohn /src/src/gcc/testsuite/c-c++-common/cilk-plus/CK/sync_wo_spawn.c -fno-diagnosti cs-show-caret -fdiagnostics-color=never

RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-04 Thread Iyer, Balaji V
path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp Hi! On 30 Oct 2013, at 20:55, Joseph S. Myers wrote: On Wed, 30 Oct 2013, Tobias Burnus wrote: On the other hand, one could use the existence of libcilkrts* as detected by the patch to decide whether to link or not: If the library

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-03 Thread Iain Sandoe
Hi! On 30 Oct 2013, at 20:55, Joseph S. Myers wrote: On Wed, 30 Oct 2013, Tobias Burnus wrote: On the other hand, one could use the existence of libcilkrts* as detected by the patch to decide whether to link or not: If the library is there, one can link – if not found, it is unlikely to

RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Iyer, Balaji V
Hello Everyone, What I ideally wanted to do with my testsuite files was that I want all the Cilk keywords test to compile no matter what the architecture is, but it should only run in certain architectures where the runtime is enabled (this is known statically and thus the testsuite

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 09:09, Iyer, Balaji V wrote: Hello Everyone, What I ideally wanted to do with my testsuite files was that I want all the Cilk keywords test to compile no matter what the architecture is, but it should only run in certain architectures where the runtime is enabled (this is known

RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Iyer, Balaji V
-Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Wednesday, October 30, 2013 1:08 PM To: Iyer, Balaji V; Tobias Burnus; gcc patches Subject: Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp On 10/30/13 09:09, Iyer

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Joseph S. Myers
On Wed, 30 Oct 2013, Jeff Law wrote: /* { dg-do compile } */ /* { dg-do run { target i?86-*-* x86-64-*-* } } */ But with an effective-target keyword cilkplusrts or similar, rather than hardcoding the same list of targets in lots of places, please. -- Joseph S. Myers jos...@codesourcery.com

RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Iyer, Balaji V
-Original Message- From: Joseph Myers [mailto:jos...@codesourcery.com] Sent: Wednesday, October 30, 2013 1:15 PM To: Jeff Law Cc: Iyer, Balaji V; Tobias Burnus; gcc patches Subject: Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 11:12, Iyer, Balaji V wrote: -Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Wednesday, October 30, 2013 1:08 PM To: Iyer, Balaji V; Tobias Burnus; gcc patches Subject: Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 11:16, Iyer, Balaji V wrote: -Original Message- From: Joseph Myers [mailto:jos...@codesourcery.com] Sent: Wednesday, October 30, 2013 1:15 PM To: Jeff Law Cc: Iyer, Balaji V; Tobias Burnus; gcc patches Subject: Re: Testsuite / Cilk Plus: Include library path in compile

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Tobias Burnus
Iyer, Balaji V wrote: What I ideally wanted to do with my testsuite files was that I want all the Cilk keywords test to compile no matter what the architecture is, but it should only run in certain architectures where the runtime is enabled (this is known statically and thus the testsuite

RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Iyer, Balaji V
* * * Actually, I was wondering whether -fcilkplus should always automatically link libcilkrts - akin to -fopenmp which links libgomp. Currently, one has to specify it manually.* Yes, I would like that to happen. Do you have any pointers about how to do that?

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Tobias Burnus
Iyer, Balaji V wrote: * * * Actually, I was wondering whether -fcilkplus should always automatically link libcilkrts - akin to -fopenmp which links libgomp. Currently, one has to specify it manually.* Yes, I would like that to happen. Do you have any pointers about how to do that? Well, if

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 13:27, Iyer, Balaji V wrote: * * * Actually, I was wondering whether -fcilkplus should always automatically link libcilkrts - akin to -fopenmp which links libgomp. Currently, one has to specify it manually.* Yes, I would like that to happen. Do you have any pointers about how to

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 04:34, Tobias Burnus wrote: Without that patch, which I have copied from asan-dg.exp, I get tons of failures because ld cannot find libcilkrts. OK for committal? Tobias cilk.diff 2013-10-30 Tobias Burnusbur...@net-b.de * gcc.dg/cilk-plus/cilk-plus.exp: Add the

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Joseph S. Myers
On Wed, 30 Oct 2013, Tobias Burnus wrote: On the other hand, one could use the existence of libcilkrts* as detected by the patch to decide whether to link or not: If the library is there, one can link – if not found, it is unlikely to work (unless it is, e.g. found in /usr/lib). The way to