Re: RE :Re: RE :Re: hashtable local iterator

2012-01-03 Thread François Dumont
Attached patch applied. 2012-01-03 François Dumont fdum...@gcc.gnu.org * include/bits/hashtable_policy.h (_Ebo_helper): Rename to the more specific _Hashtable_ebo_helper. Hide this implementation detail thanks to private inheritance. I was about to roll the

Re: RE :Re: RE :Re: hashtable local iterator

2012-01-03 Thread Paolo Carlini
On 01/03/2012 09:36 PM, François Dumont wrote: I was about to roll the ChangeLog but I saw that there is already a January entry in it so I keep on adding to the current one. For the record, it's just that I was in a hurry, there is no plan behind that. Paolo.

Re: RE :Re: RE :Re: hashtable local iterator

2011-12-31 Thread Jonathan Wakely
On 29 December 2011 18:00, François Dumont wrote: Attached patch applied. Thanks!        (_Local_iterator_base, _Locale_iterator, _Locale_const_iterator): I've fixed these two instances of Locale in the ChangeLog I might also rename _Ebo_helper to something more specific such as

Re: RE :Re: RE :Re: hashtable local iterator

2011-12-29 Thread Oleg Endo
On Thu, 2011-12-29 at 19:00 +0100, François Dumont wrote: Attached patch applied. 2011-12-29 François Dumont fdum...@gcc.gnu.org PR libstdc++/51608 [...] After this patch I'm getting the following error when building a gcc cross compiler with make all:

Re: RE :Re: RE :Re: hashtable local iterator

2011-12-29 Thread Marc Glisse
On Thu, 29 Dec 2011, Oleg Endo wrote: On Thu, 2011-12-29 at 19:00 +0100, François Dumont wrote: Attached patch applied. 2011-12-29 François Dumont fdum...@gcc.gnu.org PR libstdc++/51608 [...] After this patch I'm getting the following error when building a gcc cross

Re: RE :Re: RE :Re: hashtable local iterator

2011-12-29 Thread Oleg Endo
On Thu, 2011-12-29 at 21:51 +0100, Marc Glisse wrote: On Thu, 29 Dec 2011, Oleg Endo wrote: On Thu, 2011-12-29 at 19:00 +0100, François Dumont wrote: Attached patch applied. 2011-12-29 François Dumont fdum...@gcc.gnu.org PR libstdc++/51608 [...] After this

Re: RE :Re: RE :Re: hashtable local iterator

2011-12-29 Thread Paolo Carlini
On 12/29/2011 10:33 PM, Oleg Endo wrote: Yes, _N is defined somewhere else (no idea where yet...). Renaming _N to _Nn helps. _N in any case is a Solaris (at least) badname, should never be used. Likewise any other _ single capital, to be safe. I'll fix that. Francois, please be more careful in

Re: RE :Re: RE :Re: hashtable local iterator

2011-12-29 Thread Paolo Carlini
... applied the below (sanity checked x86_64-linux). Thanks, Paolo. /// 2011-12-29 Paolo Carlini paolo.carl...@oracle.com * include/bits/hashtable_policy.h (struct _Ebo_helper): Don't use _N, badname on Solaris; minor stylistic changes. Index: