Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v4]

2018-12-04 Thread Pedro Alves
On 12/04/2018 01:59 PM, Nick Clifton wrote: > OK then, here is a fourth revision of the patch. The issue pointed out by https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02592.html is still present in this version. Also, noticed a typo here: > +/* If DMGL_NO_RECURE_LIMIT is not enabled, then

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v4]

2018-12-04 Thread Nick Clifton
Hi Ian, >>> Shouldn't we make it fool-proof by instead introducing a >>> DMGL_NO_RECURSION_LIMIT > You don't need my blessing--I wrote that code ages ago--but I agree > with Richard that in practice it's OK to limit recursion depth by > default. Real symbols have very limited recursion