Re: RFA (symtab): PATCH to symtab_node::nonzero_address DECL_COMDAT handling for c++/80485

2018-06-11 Thread Jeff Law
On 06/05/2018 12:56 AM, Jason Merrill wrote: > On Thu, May 24, 2018 at 11:36 PM, Jeff Law wrote: >> On 05/19/2018 07:07 AM, Jason Merrill wrote: >>> A comment earlier in in nonzero_address says, "Important case of WEAK >>> we want to do well are comdats. Those are handled by later check for >>>

Re: RFA (symtab): PATCH to symtab_node::nonzero_address DECL_COMDAT handling for c++/80485

2018-06-05 Thread Jason Merrill
On Thu, May 24, 2018 at 11:36 PM, Jeff Law wrote: > On 05/19/2018 07:07 AM, Jason Merrill wrote: >> A comment earlier in in nonzero_address says, "Important case of WEAK >> we want to do well are comdats. Those are handled by later check for >> definition." But in this case we aren't handling

Re: RFA (symtab): PATCH to symtab_node::nonzero_address DECL_COMDAT handling for c++/80485

2018-05-24 Thread Jeff Law
On 05/19/2018 07:07 AM, Jason Merrill wrote: > A comment earlier in in nonzero_address says, "Important case of WEAK > we want to do well are comdats. Those are handled by later check for > definition." But in this case we aren't handling this comdat function > well, we return false because it is

RFA (symtab): PATCH to symtab_node::nonzero_address DECL_COMDAT handling for c++/80485

2018-05-19 Thread Jason Merrill
A comment earlier in in nonzero_address says, "Important case of WEAK we want to do well are comdats. Those are handled by later check for definition." But in this case we aren't handling this comdat function well, we return false because it is DECL_WEAK and DECL_EXTERNAL (because we aren't at