Re: RFC: PATCH to add abi_tag attribute

2012-11-28 Thread Florian Weimer
On 11/23/2012 03:24 PM, Jason Merrill wrote: On 11/23/2012 04:58 AM, Florian Weimer wrote: Okay, this might work in the sense that it flags the relevant cases. I'm still not convinced that this actually helps programmers that much because it pretty much separates the two worlds. If this is the

Re: RFC: PATCH to add abi_tag attribute

2012-11-23 Thread Florian Weimer
On 11/15/2012 02:51 AM, Jason Merrill wrote: On 11/11/2012 11:58 PM, Jason Merrill wrote: On 11/11/2012 08:01 AM, Florian Weimer wrote: I'm not sure if this sufficiently far-reaching. It seems that this doesn't allow me to implement a virtual function which takes a std::string parameter in

Re: RFC: PATCH to add abi_tag attribute

2012-11-23 Thread Jason Merrill
On 11/23/2012 04:58 AM, Florian Weimer wrote: Okay, this might work in the sense that it flags the relevant cases. I'm still not convinced that this actually helps programmers that much because it pretty much separates the two worlds. If this is the intend, surely there are simpler approaches

Re: RFC: PATCH to add abi_tag attribute

2012-11-14 Thread Jason Merrill
On 11/11/2012 11:58 PM, Jason Merrill wrote: On 11/11/2012 08:01 AM, Florian Weimer wrote: I'm not sure if this sufficiently far-reaching. It seems that this doesn't allow me to implement a virtual function which takes a std::string parameter in new-ABI-mode when the base class is also used in

Re: RFC: PATCH to add abi_tag attribute

2012-11-11 Thread Florian Weimer
On 11/06/2012 05:03 AM, Jason Merrill wrote: +The @code{abi_tag} attribute can be applied to a function or class +declaration. It modifies the mangled name of the function or class to +incorporate the tag name, in order to distinguish the function or +class from an earlier version with a

Re: RFC: PATCH to add abi_tag attribute

2012-11-11 Thread Jason Merrill
On 11/11/2012 08:01 AM, Florian Weimer wrote: I'm not sure if this sufficiently far-reaching. It seems that this doesn't allow me to implement a virtual function which takes a std::string parameter in new-ABI-mode when the base class is also used in old-ABI-mode. Ah, yes; since virtual

Re: RFC: PATCH to add abi_tag attribute

2012-11-10 Thread Jason Merrill
The demangler change was handling the tags in the wrong place; I'm writing them out with unqualified names, so the demangler should expect them in the same place. Tested x86_64-pc-linux-gnu, applied to trunk. commit 75eef303e5494f27a6d9bbef68aaf3200978a8f1 Author: Jason Merrill

Re: RFC: PATCH to add abi_tag attribute

2012-11-06 Thread Jakub Jelinek
On Mon, Nov 05, 2012 at 11:03:37PM -0500, Jason Merrill wrote: As discussed at the Cauldron in Prague, this patch introduces a C++ abi_tag attribute which can be attached to a function or class to modify its mangled name and avoid name collisions with earlier versions with a different ABI. It

Re: RFC: PATCH to add abi_tag attribute

2012-11-06 Thread Jason Merrill
On 11/06/2012 06:20 AM, Jakub Jelinek wrote: On Mon, Nov 05, 2012 at 11:03:37PM -0500, Jason Merrill wrote: As discussed at the Cauldron in Prague, this patch introduces a C++ abi_tag attribute which can be attached to a function or class to modify its mangled name and avoid name collisions

RFC: PATCH to add abi_tag attribute

2012-11-05 Thread Jason Merrill
As discussed at the Cauldron in Prague, this patch introduces a C++ abi_tag attribute which can be attached to a function or class to modify its mangled name and avoid name collisions with earlier versions with a different ABI. It also adds a -Wabi-tag warning option to make the compiler